Repository navigation
test(dense): add NetCDF-4 dense-link fixture + read test - #56
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Adds testdata/dense_links.h5 (generated via ncgen -4 from the committed dense_links.cdl): a root group with 16 datasets that exceeds HDF5's 8-link compact threshold, so links are stored in a fractal heap + v2 B-tree. The heap header has the ChecksumDirBlocks flag set, so reading it covers both the ReadDenseHeapObjects path and the checksummed direct-block branch. Requested by @kolkov in scigolib#55 to unblock dense-link coverage for v0.14.0.
rhaist
force-pushed
the
test/dense-link-fixture
branch
from
June 25, 2026 15:30
23f4537 to
9421957
Compare
kolkov
approved these changes
Jun 25, 2026
kolkov
left a comment
kolkov
left a comment
Contributor
There was a problem hiding this comment.
Exactly what we needed — thank you for the quick follow-up.
The fixture covers both ReadDenseHeapObjects and the ChecksumDirBlocks direct-block branch. Including the CDL source is a nice touch for reproducibility.
All CI green. Merging.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a small NetCDF-4 dense-link fixture (
testdata/dense_links.h5, generated from the committeddense_links.cdl) and a read test, as requested by @kolkov in #55.Root group has 16 datasets — past HDF5's 8-link compact threshold — so links are stored in a fractal heap + v2 B-tree. The heap header has
ChecksumDirBlocksset, so the test covers bothReadDenseHeapObjectsand the checksummed direct-block branch. Unblocks dense-link coverage for v0.14.0.Round-trip gap (CreateDenseGroup writer, tiny-ID vs managed-ID) is left for the separate writer fix.