Fix count items stuck on empty bucket list by SylvainSenechal · Pull Request #402 · scality/s3utils

SylvainSenechal · 2026-06-24T16:02:32Z

Fix 1 bug and 1 risk :

Count item never finishes when the artesca has 0 buckets
While doing local tests, I found the scripts was crashing on non existent replicationInfo metadata : added defensive code

bert-e · 2026-06-24T16:02:36Z

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

SylvainSenechal · 2026-06-24T16:03:02Z

No version bumps, we said we will release it with 4.3.0 and we have other ongoing prs opened

we have other ongoing prs opened

other PRs target 1.18, so will not help deliver this in 4.3.0 : best to make the release already for 1.16 and 1.17 ?

bert-e · 2026-06-24T16:04:19Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

francoisferrand · 2026-06-24T16:12:27Z

we have other ongoing prs opened

other PRs target 1.18, so will not help deliver this in 4.3.0 : best to make the release already for 1.16 and 1.17 ?

Issue: S3UTILS-243

SylvainSenechal · 2026-06-25T08:53:31Z

/create_integration_branches

SylvainSenechal · 2026-06-25T08:53:36Z

/approve

bert-e · 2026-06-25T08:53:42Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/S3UTILS-243 into
development/1.16
w/1.17/bugfix/S3UTILS-243 will be merged into development/1.17
w/1/bugfix/S3UTILS-243 will be merged into development/1

The following branches will NOT be impacted:

development/1.13
development/1.14
development/1.15
development/1.4
development/1.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2026-06-25T08:53:43Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

bert-e · 2026-06-25T08:54:35Z

Build failed

The build for commit did not succeed in branch bugfix/S3UTILS-243

The following options are set: approve, create_integration_branches

Issue: S3UTILS-243

SylvainSenechal · 2026-06-25T09:12:00Z

/help

bert-e · 2026-06-25T09:12:05Z

Help page

The following options and commands are available at this time.

Options

name	description	privileged	authored
➡️ after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
➡️ bypass_author_approval	Bypass the pull request author's approval	⭐
➡️ bypass_build_status	Bypass the build and test status	⭐
➡️ bypass_commit_size	Bypass the check on the size of the changeset `TBA`	⭐
➡️ bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
➡️ bypass_jira_check	Bypass the Jira issue check	⭐
➡️ bypass_peer_approval	Bypass the pull request peers' approval	⭐
➡️ bypass_leader_approval	Bypass the pull request leaders' approval	⭐
➡️ approve	Instruct Bert-E that the author has approved the pull request.		✍️
➡️ create_pull_requests	Allow the creation of integration pull requests.
➡️ create_integration_branches	Allow the creation of integration branches.
➡️ no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
➡️ unanimity	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
➡️ wait	Instruct Bert-E not to run until further notice.

Commands

name	description	privileged
➡️ help	Print Bert-E's manual in the pull request.
➡️ status	Print Bert-E's current status in the pull request `TBA`
➡️ clear	Remove all comments from Bert-E from the history `TBA`
➡️ retry	Re-start a fresh build `TBA`
➡️ build	Re-start a fresh build `TBA`
➡️ force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
➡️ reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

The following options are set: approve, create_integration_branches

bert-e · 2026-06-25T09:12:16Z

Build failed

The build for commit did not succeed in branch bugfix/S3UTILS-243

The following options are set: approve, create_integration_branches

SylvainSenechal · 2026-06-25T09:12:45Z

/status

bert-e · 2026-06-25T09:12:49Z

Status

Status report is not available.

The following options are set: approve, create_integration_branches

bert-e · 2026-06-25T09:13:03Z

Build failed

The build for commit did not succeed in branch bugfix/S3UTILS-243

The following options are set: approve, create_integration_branches

SylvainSenechal · 2026-06-25T09:14:07Z

/force_reset

bert-e · 2026-06-25T09:14:16Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve, create_integration_branches, wait

SylvainSenechal · 2026-06-25T09:14:53Z

/status

bert-e · 2026-06-25T09:14:57Z

Status

Status report is not available.

The following options are set: approve, create_integration_branches, wait

codecov · 2026-06-25T09:20:06Z

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.27%. Comparing base (9a5c496) to head (f4ea39f).

Files with missing lines	Patch %	Lines
CountItems/CountManager.js	33.33%	2 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##           development/1.16     #402      +/-   ##
====================================================
- Coverage             45.28%   45.27%   -0.01%     
====================================================
  Files                    85       85              
  Lines                  6049     6052       +3     
  Branches               1283     1284       +1     
====================================================
+ Hits                   2739     2740       +1     
- Misses                 3264     3266       +2     
  Partials                 46       46

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SylvainSenechal · 2026-06-25T09:32:06Z

/approve

bert-e · 2026-06-25T09:49:44Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/S3UTILS-243 into
development/1.16
w/1.17/bugfix/S3UTILS-243 will be merged into development/1.17
w/1/bugfix/S3UTILS-243 will be merged into development/1

The following branches will NOT be impacted:

development/1.13
development/1.14
development/1.15
development/1.4
development/1.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve, create_integration_branches

SylvainSenechal · 2026-06-25T10:10:33Z

/approve

bert-e · 2026-06-25T10:34:27Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/1.16
✔️ development/1.17
✔️ development/1

The following branches have NOT changed:

development/1.13
development/1.14
development/1.15
development/1.4
development/1.7

This pull request did not target the following hotfix branch(es) so they
were left untouched:

hotfix/1.14.0

Please check the status of the associated issue S3UTILS-243.

Goodbye sylvainsenechal.

The following options are set: approve, create_integration_branches

SylvainSenechal commented Jun 24, 2026

View reviewed changes

scality deleted a comment from bert-e Jun 24, 2026

SylvainSenechal requested review from a team, benzekrimaha and delthas June 24, 2026 16:04

francoisferrand approved these changes Jun 24, 2026

View reviewed changes

maeldonn approved these changes Jun 24, 2026

View reviewed changes

Comment thread CountItems/CountManager.js Outdated

SylvainSenechal added 2 commits June 25, 2026 10:31

fix bug with count items hanging when ran against 0 buckets

c761f9e

Issue: S3UTILS-243

add defensive code around replicationInfo

24d04b4

Issue: S3UTILS-243

SylvainSenechal force-pushed the bugfix/S3UTILS-243 branch from 6aaaa05 to 24d04b4 Compare June 25, 2026 08:33

fix broken test because of empty bucketInfos not properly created

f4ea39f

Issue: S3UTILS-243

SylvainSenechal force-pushed the bugfix/S3UTILS-243 branch from d471b11 to f4ea39f Compare June 25, 2026 09:13

scality deleted a comment from SylvainSenechal Jun 25, 2026

scality deleted a comment from bert-e Jun 25, 2026

bert-e merged commit f4ea39f into development/1.16 Jun 25, 2026
14 checks passed

bert-e deleted the bugfix/S3UTILS-243 branch June 25, 2026 10:34

Uh oh!

Conversation

SylvainSenechal commented Jun 24, 2026

Uh oh!

bert-e commented Jun 24, 2026

Hello sylvainsenechal,

Uh oh!

SylvainSenechal Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

francoisferrand Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

bert-e commented Jun 24, 2026

Request integration branches

Uh oh!

francoisferrand Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SylvainSenechal commented Jun 25, 2026

Uh oh!

SylvainSenechal commented Jun 25, 2026

Uh oh!

bert-e commented Jun 25, 2026

Integration data created

Uh oh!

bert-e commented Jun 25, 2026

Waiting for approval

Uh oh!

bert-e commented Jun 25, 2026

Build failed

Uh oh!

SylvainSenechal commented Jun 25, 2026

Uh oh!

bert-e commented Jun 25, 2026

Help page

Options

Commands

Uh oh!

bert-e commented Jun 25, 2026

Build failed

Uh oh!

SylvainSenechal commented Jun 25, 2026

Uh oh!

bert-e commented Jun 25, 2026

Status

Uh oh!

bert-e commented Jun 25, 2026

Build failed

Uh oh!

SylvainSenechal commented Jun 25, 2026

Uh oh!

bert-e commented Jun 25, 2026

Reset complete

Uh oh!

SylvainSenechal commented Jun 25, 2026

Uh oh!

bert-e commented Jun 25, 2026

Status

Uh oh!

codecov Bot commented Jun 25, 2026

Codecov Report

Uh oh!

SylvainSenechal commented Jun 25, 2026

Uh oh!

bert-e commented Jun 25, 2026

Integration data created

Uh oh!

SylvainSenechal commented Jun 25, 2026

Uh oh!

bert-e commented Jun 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone