OSIS-164: pin the Claude Code review model to claude-opus-4-8#160
Merged
Conversation
review.yml inherited claude-opus-4-6 from scality/workflows' claude-code-review.yml@v2.8.3. Override the model input locally to claude-opus-4-8 (stronger bug-finding; available on Vertex).
anurag4DSB
force-pushed
the
improvement/OSIS-164-pin-claude-review-model
branch
from
b3a5a6d to
ab8ad45
Compare
dvasilas
approved these changes
Jun 26, 2026
BourgoisMickael
approved these changes
Jun 26, 2026
BourgoisMickael
left a comment
BourgoisMickael
left a comment
There was a problem hiding this comment.
Should we update the shared reusable workflow as well to have this in every repo ?
fredmnl
approved these changes
Jun 26, 2026
fredmnl
left a comment
fredmnl
left a comment
There was a problem hiding this comment.
Should we change it at the workflow level?
Contributor
Author
We should indeed. |
Contributor
Author
|
In the latest commit I removed the model spec and bumped the workflow as it uses Opus 4.8 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent: why does this change exist?
The Code Review workflow inherits
claude-opus-4-6from the shared reusable workflow's default. Pinning the model locally moves PR reviews ontoclaude-opus-4-8, which is stronger at bug-finding.System impact: what's affected, including downstream?
Only
.github/workflows/review.yml. Adds awith: model:input to the existing call ofscality/workflows'claude-code-review.yml@v2.8.3; the shared workflow is untouched. Still runs on Vertex AI with the bare model ID.Preserved behavior: what explicitly stays the same?
Same reusable-workflow version, same Vertex auth/secrets, same triggers and skip-label behavior. Only the review model changes.
Intended change: what's different after this PR?
PR reviews run on
claude-opus-4-8instead ofclaude-opus-4-6.Verification: how do we know this worked, or how would we know if it didn't?
The next PR review run logs
claude-opus-4-8as the model. If the Vertex project has not enabled Opus 4.8 and a run errors model-not-found, fall back toclaude-opus-4-7.