Skip to content

Bump werelogs to 8.2.4 #6207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maeldonn wants to merge 1 commit into
base: development/9.3
Choose a base branch
from
+5 −12
Open

Bump werelogs to 8.2.4 #6207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"utf8": "^3.0.0",
"uuid": "^11.0.3",
"vaultclient": "scality/vaultclient#8.5.3",
"werelogs": "scality/werelogs#8.2.2",
"werelogs": "scality/werelogs#8.2.4",
"ws": "^8.18.0",
"xml2js": "^0.6.2"
},
Expand Down Expand Up @@ -87,6 +87,7 @@
"tv4": "^1.3.0"
},
"resolutions": {
"werelogs": "scality/werelogs#8.2.4",

@DarkIsDude DarkIsDude Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?

@maeldonn maeldonn Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of our dependencies also use werelogs. This resolution forces every one of them onto 8.2.4 so they all pick up the fix.

@francoisferrand francoisferrand Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • best to fix dependencies IMHO
  • may use ^ (here and/or in deps) to ensure same version can be used where compatible
  • yarn knows how to have different copies of dependency : not the role of the "top level" package to override resolution/dependency inside each package it depends on

"jsonwebtoken": "^9.0.0",
"nan": "v2.22.0",
"fast-xml-parser": "^5.5.6",
Expand Down
14 changes: 3 additions & 11 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12614,17 +12614,9 @@ webidl-conversions@^7.0.0:
resolved "https://registry.yarnpkg.com/webidl-conversions/-/webidl-conversions-7.0.0.tgz#256b4e1882be7debbf01d05f0aa2039778ea080a"
integrity sha512-VwddBukDzu71offAQR975unBIGqfKZpM+8ZX6ySk8nYhVoo5CYaZyzt3YBvYtRtO+aoGlqxPg/B87NGVZ/fu6g==

"werelogs@github:scality/werelogs#8.2.2", werelogs@scality/werelogs#8.2.2:
version "8.2.2"
uid e53bef5145697bf8af940dcbe59408988d64854f
resolved "https://codeload.github.com/scality/werelogs/tar.gz/e53bef5145697bf8af940dcbe59408988d64854f"
dependencies:
fast-safe-stringify "^2.1.1"
safe-json-stringify "^1.2.0"

werelogs@scality/werelogs#8.2.0:
version "8.2.0"
resolved "https://codeload.github.com/scality/werelogs/tar.gz/7bf334cea94002d118f27d7ec1c7a5af74b51b8d"
"werelogs@github:scality/werelogs#8.2.2", werelogs@scality/werelogs#8.2.0, werelogs@scality/werelogs#8.2.2, werelogs@scality/werelogs#8.2.4:
version "8.2.4"
resolved "https://codeload.github.com/scality/werelogs/tar.gz/a7bbb5917a08b035d3763b24b070d517483d6982"
dependencies:
fast-safe-stringify "^2.1.1"
safe-json-stringify "^1.2.0"
Expand Down
Loading