Skip to content

Publish arsenal to GitHub Packages on release#2657

Draft
delthas wants to merge 1 commit into
development/8.4from
improvement/ARSN-605/publish-to-github-packages
Draft

Publish arsenal to GitHub Packages on release#2657
delthas wants to merge 1 commit into
development/8.4from
improvement/ARSN-605/publish-to-github-packages

Conversation

@delthas

@delthas delthas commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Phase 1 of moving arsenal off git-dependency distribution: publish @scality/arsenal to GitHub Packages on release. Non-breaking — existing git-dependency consumers (cloudserver, backbeat, vault2) are untouched; consumer migration is a later, organic step.

The manual release workflow (workflow_dispatch) now:

  • takes a version input and stamps package.json name/version/files at publish time via jq (the committed version is never bumped — the tag is the source of truth);
  • guards: release branch only (development/* or hotfix/*), version matches the branch major.minor line, release doesn't already exist;
  • builds (yarn build) and publishes @scality/arsenal to npm.pkg.github.com via the built-in GITHUB_TOKEN (packages: write);
  • is idempotent on re-run (tolerates npm E409 cannot publish over existing version) and creates the GitHub release + tag with the GitHub Packages URL appended to the notes.

package.json gains types and publishConfig.access: restricted; files is stamped at publish (not committed) so git-dependency consumers keep receiving the full tree until they migrate.

Aligned with the DevEx initiative (S3C-9725) and its pilot (Guidelines#206) on registry, scope, auth, and guards. Deliberately GitHub-Packages-only/private and version-stamped-in-CI rather than a committed bump (the automation the pilot deferred). Rationale and references in ARSN-605.

Issue: ARSN-605

@bert-e

bert-e commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Jun 29, 2026
@bert-e

bert-e commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.00%. Comparing base (7fca398) to head (ae40893).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/8.4    #2657      +/-   ##
===================================================
- Coverage            74.02%   74.00%   -0.02%     
===================================================
  Files                  229      229              
  Lines                18503    18503              
  Branches              3845     3845              
===================================================
- Hits                 13696    13694       -2     
- Misses                4802     4804       +2     
  Partials                 5        5              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@delthas delthas force-pushed the improvement/ARSN-605/publish-to-github-packages branch from c9deb37 to a75e604 Compare June 29, 2026 13:13
Extend the manual release workflow to build and publish @scality/arsenal
to GitHub Packages. The scoped name, version, and files list are stamped
into package.json at publish time (jq), and the committed `private: true`
is stripped just for the publish -- so the committed version is never
bumped, the source stays private/unpublishable by default, and
git-dependency consumers keep receiving the full tree. npm publish is
idempotent on re-run (E409 tolerated), and the GitHub release notes link
to the published package.

Issue: ARSN-605
@delthas delthas force-pushed the improvement/ARSN-605/publish-to-github-packages branch from a75e604 to ae40893 Compare June 29, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants