Publish arsenal to GitHub Packages on release#2657
Draft
delthas wants to merge 1 commit into
Draft
Conversation
Contributor
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/8.4 #2657 +/- ##
===================================================
- Coverage 74.02% 74.00% -0.02%
===================================================
Files 229 229
Lines 18503 18503
Branches 3845 3845
===================================================
- Hits 13696 13694 -2
- Misses 4802 4804 +2
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
c9deb37 to
a75e604
Compare
Extend the manual release workflow to build and publish @scality/arsenal to GitHub Packages. The scoped name, version, and files list are stamped into package.json at publish time (jq), and the committed `private: true` is stripped just for the publish -- so the committed version is never bumped, the source stays private/unpublishable by default, and git-dependency consumers keep receiving the full tree. npm publish is idempotent on re-run (E409 tolerated), and the GitHub release notes link to the published package. Issue: ARSN-605
a75e604 to
ae40893
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of moving arsenal off git-dependency distribution: publish
@scality/arsenalto GitHub Packages on release. Non-breaking — existing git-dependency consumers (cloudserver, backbeat, vault2) are untouched; consumer migration is a later, organic step.The manual release workflow (
workflow_dispatch) now:versioninput and stampspackage.jsonname/version/filesat publish time viajq(the committedversionis never bumped — the tag is the source of truth);development/*orhotfix/*), version matches the branch major.minor line, release doesn't already exist;yarn build) and publishes@scality/arsenaltonpm.pkg.github.comvia the built-inGITHUB_TOKEN(packages: write);E409 cannot publish over existing version) and creates the GitHub release + tag with the GitHub Packages URL appended to the notes.package.jsongainstypesandpublishConfig.access: restricted;filesis stamped at publish (not committed) so git-dependency consumers keep receiving the full tree until they migrate.Aligned with the DevEx initiative (S3C-9725) and its pilot (Guidelines#206) on registry, scope, auth, and guards. Deliberately GitHub-Packages-only/private and version-stamped-in-CI rather than a committed bump (the automation the pilot deferred). Rationale and references in ARSN-605.
Issue: ARSN-605