Add manual release CI workflow (release.yaml)#2656
Conversation
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
fe56be3 to
3500bd2
Compare
3500bd2 to
6490ff3
Compare
Add a workflow_dispatch release.yaml for arsenal. Arsenal is a library (no Docker image) consumed as a git dependency where the tag equals the package.json version, so the release reduces to creating the GitHub release + tag, replacing the manual `gh release create`. The workflow reads the version from package.json (no manual tag input) and fails if it is missing, fails if that release already exists, and rejects dispatches from any branch other than development/* or hotfix/* so a release cannot be cut from un-merged code. github.ref_name is passed via an env var to avoid shell injection in the guard step. Issue: ARSN-604
6490ff3 to
dd5ee2d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/8.3 #2656 +/- ##
================================================
Coverage 73.54% 73.54%
================================================
Files 222 222
Lines 18188 18188
Branches 3786 3786
================================================
Hits 13377 13377
Misses 4806 4806
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
francoisferrand
left a comment
There was a problem hiding this comment.
As logic is added to release workflow, bugs are also added : which is esp. critical for releases, which are only used seldom and especially when we need (urgently) a release... Thus (non-trivial) release workflow should be tested, as we do for exemple in Zenko
| GH_TOKEN: ${{ github.token }} | ||
| VERSION: ${{ steps.version.outputs.version }} | ||
| run: | | ||
| if gh release view "$VERSION" --repo "$GITHUB_REPOSITORY" \ |
There was a problem hiding this comment.
this only checks the release, not the tag.
if the release was previously aborted or removed, but the tag is still there, we could end up in a weird state: the tag was created -possibly on another commit- and we would now release a different commit (and possibly move the tag)
Summary
Arsenal has no release workflow, unlike
cloudserver,vault2, andbackbeat, which each ship aworkflow_dispatchrelease pipeline. Today arsenal releases are cut by hand viagh release create <version> --generate-notes.This adds
.github/workflows/release.yaml, triggered manually (workflow_dispatch), that:package.json(no manual tag input), so the released tag can never drift from what consumers pin (git+https://github.com/scality/arsenal#<tag>).softprops/action-gh-releaseotherwise updates an existing release silently).generate_release_notes: true), targeting the dispatched commit.Arsenal is a library (
private: true, no Docker image), so the workflow reduces to the GitHub-release step only — no Docker/oras steps. Build artifacts continue to be published by the existing per-pushcompilejob intests.yaml. The release name is kept as the bare version (e.g.8.5.1) to match arsenal's existing release history.Issue: ARSN-604