Skip to content

Bumps werelogs from 8.2.2 to 8.2.4 and bumps arsenal to 8.3.13#2655

Merged
bert-e merged 4 commits into
development/8.3from
bugfix/ARSN-603/werelogs
Jun 25, 2026
Merged

Bumps werelogs from 8.2.2 to 8.2.4 and bumps arsenal to 8.3.13#2655
bert-e merged 4 commits into
development/8.3from
bugfix/ARSN-603/werelogs

Conversation

@maeldonn

@maeldonn maeldonn commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Issue: ARSN-603

@maeldonn
Use logHelper for AwsClient setup error logging
7d63322 
Route the setup error through logHelper so the data store name and
client type are included, consistent with the rest of AwsClient's
logging.

Issue: ARSN-603
@maeldonn maeldonn requested review from a team, benzekrimaha and delthas June 25, 2026 08:37
@bert-e

bert-e commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@maeldonn maeldonn force-pushed the bugfix/ARSN-603/werelogs branch from edb762e to 75bd742 Compare June 25, 2026 08:48
@scality scality deleted a comment from bert-e Jun 25, 2026
maeldonn added 2 commits June 25, 2026 11:19
@maeldonn
Build a fresh RequestLogger per retrieveData test case
8856021 
werelogs 8.2.3 moved the "RequestLogger.end() has been called more than
once" guard from log() into doLogIO(), where it now runs inside the
dump's forEach over this.entries. The first end() in one it() leaves
elapsedTime set on the shared module-level RequestLogger; the next test
hits the guard, which calls this.error() inside the forEach and re-enters
log()/doLogIO() over the still-buffered end-entry, blowing the stack.

Build the RequestLogger fresh in beforeEach so each case starts with
elapsedTime null and the recursion path is never reached. No production
code change.

Issue: ARSN-603
@maeldonn
Bump package.json to 8.3.13
6c3772d 
Issue: ARSN-603
@maeldonn maeldonn force-pushed the bugfix/ARSN-603/werelogs branch from 75bd742 to 6c3772d Compare June 25, 2026 09:19
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.56%. Comparing base (7fd2be6) to head (6c3772d).

Files with missing lines Patch % Lines
lib/storage/data/external/AwsClient.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           development/8.3    #2655      +/-   ##
===================================================
+ Coverage            73.54%   73.56%   +0.01%     
===================================================
  Files                  222      222              
  Lines                18188    18188              
  Branches              3786     3762      -24     
===================================================
+ Hits                 13377    13380       +3     
+ Misses                4806     4803       -3     
  Partials                 5        5

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

francoisferrand
francoisferrand approved these changes Jun 25, 2026
View reviewed changes
Comment thread lib/storage/data/external/AwsClient.js
@bert-e

bert-e commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue ARSN-603 contains:

  • 8.3.13

  • 8.4.12

  • 8.5.1

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.3.13

  • 8.4.13

  • 8.5.2

Please check the Fix Version/s of ARSN-603, or the target
branch of this pull request.

@maeldonn

maeldonn commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

/approve

@scality scality deleted a comment from bert-e Jun 25, 2026
@bert-e

bert-e commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Conflict

A conflict has been raised during the creation of
integration branch w/8.4/bugfix/ARSN-603/werelogs with contents from bugfix/ARSN-603/werelogs
and development/8.4.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/8.4/bugfix/ARSN-603/werelogs origin/development/8.4
 git merge origin/bugfix/ARSN-603/werelogs
 # <intense conflict resolution>
 git commit
 git push -u origin w/8.4/bugfix/ARSN-603/werelogs

The following options are set: approve

@bert-e

bert-e commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Conflict

A conflict has been raised during the creation of
integration branch w/8.5/bugfix/ARSN-603/werelogs with contents from w/8.4/bugfix/ARSN-603/werelogs
and development/8.5.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/8.5/bugfix/ARSN-603/werelogs origin/development/8.5
 git merge origin/w/8.4/bugfix/ARSN-603/werelogs
 # <intense conflict resolution>
 git commit
 git push -u origin w/8.5/bugfix/ARSN-603/werelogs

The following options are set: approve

@bert-e

bert-e commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.3

  • ✔️ development/8.4

  • ✔️ development/8.5

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1
  • development/8.2

This pull request did not target the following hotfix branch(es) so they
were left untouched:

  • hotfix/7.9.0
  • hotfix/7.10.4
  • hotfix/7.10.46
  • hotfix/7.70.14
  • hotfix/7.10.57
  • hotfix/7.70.4
  • hotfix/7.8.0
  • hotfix/7.70.20
  • hotfix/7.10.29
  • hotfix/6.4.7
  • hotfix/7.4.7
  • hotfix/7.4.4
  • hotfix/7.2.0
  • hotfix/7.10.1
  • hotfix/7.4.2
  • hotfix/7.10.36
  • hotfix/7.4.5
  • hotfix/7.4.1
  • hotfix/7.10.31
  • hotfix/7.4.0
  • hotfix/7.70.25
  • hotfix/7.4.8
  • hotfix/7.6.0
  • hotfix/7.7.0
  • hotfix/7.5.0
  • hotfix/7.10.47
  • hotfix/7.4.9
  • hotfix/7.10.3
  • hotfix/7.10.43
  • hotfix/7.10.2
  • hotfix/7.4.3
  • hotfix/7.4.10
  • hotfix/7.10.0
  • hotfix/7.4.6

Please check the status of the associated issue ARSN-603.

Goodbye maeldonn.

The following options are set: approve

@bert-e bert-e merged commit 6c3772d into development/8.3 Jun 25, 2026
11 of 12 checks passed
@bert-e bert-e deleted the bugfix/ARSN-603/werelogs branch June 25, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delthas delthas delthas approved these changes
@francoisferrand francoisferrand francoisferrand approved these changes
@benzekrimaha benzekrimaha Awaiting requested review from benzekrimaha benzekrimaha was automatically assigned from scality/raving-robots
@DarkIsDude DarkIsDude Awaiting requested review from DarkIsDude
@SylvainSenechal SylvainSenechal Awaiting requested review from SylvainSenechal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maeldonn @bert-e @delthas @francoisferrand