Y26-181 - Improve nanoseq performance#2879
Open
BenTopping wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2879 +/- ##
========================================
Coverage 92.16% 92.16%
========================================
Files 432 432
Lines 9163 9164 +1
========================================
+ Hits 8445 8446 +1
Misses 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BenTopping
commented
Jun 12, 2026
| end | ||
|
|
||
| it 'raises an error when existing metadata fails to update' do | ||
| request_metadata['key1'] = 'new_value1' |
Contributor
Author
There was a problem hiding this comment.
Not sure how this was passing before as there is a check to ensure update is only called if there is a new value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SS Story sanger/sequencescape#5839
Changes proposed in this pull request
Sequencecape PR: sanger/sequencescape#5850
Notes
The main sluggishness comes from the poly_metadata checks and creation.
The changes here allow us to make use of the Sequencescape index on poly_metadata. It also fixes (an unlikely) bug in which we are currently requesting on just metadatable_id which could be the same across classes and doesn't take into account type.
We also reduce N+1 queries by getting all polymetadata for a request at once instead of individually requesting one each time. This could cause issues if a request has mass amounts of polymetadata but I cant see that so far in the existing records.
This process still takes ~20s which isn't ideal but before it was taking ~150s+.