Skip to content

Y25-623 scRNA - added a version of tenstamp creator and refactored multistamp JS#2840

Open
andrewsparkes wants to merge 18 commits into
developfrom
y25-623-scrna-aggregate-cite-sup-xp-and-inputs
Open

Y25-623 scRNA - added a version of tenstamp creator and refactored multistamp JS#2840
andrewsparkes wants to merge 18 commits into
developfrom
y25-623-scrna-aggregate-cite-sup-xp-and-inputs

Conversation

@andrewsparkes

Copy link
Copy Markdown
Member

Closes #2606

Changes proposed in this pull request

added a version of tenstamp creator and refactored multistamp JS to handle creating transfers without a submission

…andle creating transfers without a submission
@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.23%. Comparing base (7701876) to head (e57f84a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2840      +/-   ##
===========================================
+ Coverage    92.18%   92.23%   +0.04%     
===========================================
  Files          432      437       +5     
  Lines         9159     9217      +58     
===========================================
+ Hits          8443     8501      +58     
  Misses         716      716              
Flag Coverage Δ
javascript 89.59% <100.00%> (+0.21%) ⬆️
pull_request 92.23% <100.00%> (+0.04%) ⬆️
push 92.23% <100.00%> (+0.04%) ⬆️
ruby 92.63% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yoldas yoldas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with tests and documentation.

Comment thread app/frontend/javascript/shared/components/plateScanValidators.js Outdated
Comment thread app/frontend/javascript/shared/requestHelpers.js Outdated
Comment thread app/frontend/javascript/shared/transfersCreators.js

@yoldas yoldas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y25-623 - Enable scRNA Core Users to aggregate LRC GEM-X 5p CITE SUP XP/Input Plates

2 participants