#226 standardize arcade examples on GameApp module layout FIXED

[solidsole]

Findings

I reviewed the six in-scope arcade examples:

snake
flappy_bird
tetris
space_invaders
geometry_dash
pong

The main issues found were:

1. Outdated dependency version

   • All six examples were still using:

   cougr-core = "1.0.0"

   • The issue requires:

   cougr-core = "1.1.0"

2. README standard mismatch

   • snake was referenced as the maintained GameApp demonstration, but its README did not satisfy EXAMPLE_STANDARD.md §4.
   • Missing or incomplete sections included:
     • Purpose and pattern
     • Public contract API
     • Architecture overview
     • Storage model
     • Main gameplay flow
     • Cougr APIs used
     • Build and test commands
     • Known limitations

3. Missing classification banners

   • The remaining examples were not clearly marked as Transitional.
   • They lacked the required banner:

   > **Transitional example**: This example uses an older Cougr pattern and is preserved
   > for compatibility reference. For the current recommended approach, see `snake`.

4. Inconsistent module layout

   • snake, flappy_bird, and geometry_dash already had the desired layout:

   lib.rs
   components.rs
   systems.rs
   

   • tetris, space_invaders, and pong needed standard module layout cleanup.

5. Test coverage gaps

   • Some examples did not explicitly cover:
     • Invalid actions
     • GameApp tick integration

---

Fix features implemented

1. Updated dependency version

   Updated all six examples to:

   cougr-core = "1.1.0"

2. Made snake the Canonical reference

   Rewrote:

   examples/snake/README.md
   

   Added Canonical classification and all required sections from EXAMPLE_STANDARD.md §4.

3. Marked the other examples as Transitional

   Rewrote or updated READMEs for:

   examples/flappy_bird/README.md
   examples/tetris/README.md
   examples/space_invaders/README.md
   examples/geometry_dash/README.md
   examples/pong/README.md
   

   Each now includes the required Transitional banner pointing to snake.

4. Standardized module layout

   Added missing standard files:

   examples/tetris/src/components.rs
   examples/tetris/src/systems.rs
   examples/space_invaders/src/components.rs
   examples/space_invaders/src/systems.rs
   examples/pong/src/components.rs
   examples/pong/src/systems.rs
   

   Refactored older code so:

   • lib.rs focuses on contract entrypoints and wiring.
   • components.rs contains component/domain data structures.
   • systems.rs contains reusable gameplay/system helpers.

5. Added test coverage

   Added or improved tests for:

   • Invalid actions
   • GameApp tick integration

   Examples:

   • Invalid direction / invalid movement / ignored action tests.
   • Scheduler-backed GameApp tick smoke tests.

6. Preserved gameplay behavior

   The work intentionally avoided gameplay rule changes or feature additions, matching the issue’s out-of-scope requirements.

CLOSE #226

[drips-wave]

@solidsole Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[salazarsebas]

Review — request changes (all CI workflows failing)

The modular split direction is correct (pong with components.rs / systems.rs / test.rs is a good reference), and README rewrites align with the issue intent.

CI blocker — all six examples fail

Every triggered workflow fails at cargo fmt --check:

Example	Failure
snake	Extra closing brace in src/lib.rs (~line 775)
flappy_bird, geometry_dash, pong, space_invaders, tetris	Formatting violations

None of the examples reached cargo test or stellar contract build.

Required fix

Per example:

cd examples/<name>
cargo fmt
cargo fmt --check
cargo clippy --all-targets -- -D warnings
cargo test
stellar contract build

Scope gaps vs #226

• snake should be classified Canonical with a complete EXAMPLE_STANDARD README; verify all §4 sections are present.
• Transitional examples need the banner from EXAMPLE_STANDARD.md §7.
• Add or extend tests for invalid actions and GameApp tick integration where missing.

Verdict

Re-request review after all six examples pass CI end-to-end.

[solidsole]

DONE...

-All transitional templates now explicitly carry the warning banners.

-Every single arcade game matches the canonical layout structure (components.rs, systems.rs, and test.rs).

-The local tests compile and pass with flying colors under the split-module organization.

[solidsole]

PLEASE REVIEW... AND PING ME BACK

[solidsole]

@salazarsebas please review...

[salazarsebas]

The workflow keeps failing

[solidsole]

@salazarsebas please review...

[salazarsebas]

LGTM

[solidsole]

Hi @salazarsebas ,

Thanks so much for reviewing and approving the fix!

I noticed that the points for this contribution haven't been awarded on Drips yet. Usually, this happens if the underlying issue needs to be officially closed or if the distribution needs to be triggered from your side on the platform.

Could you please double-check your Drips dashboard when you get a moment to see if there's an action needed to release the rewards?

Thanks again for your time and for maintaining this project!