Repository navigation
fixes issues with canvas registering multiple times - #51
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 58ce6e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Later molecule lookups receive fresh atoms while registrations remain bound to stale atoms from the first lookup.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds per-canvas registration deduplication for canvas plugins.
Changes:
- Introduces
registerOnceusing owner identity. - Migrates built-in plugins and story renderers.
- Adds registration-count tests and a Changeset.
| File | Description |
|---|---|
.changeset/canvas-register-once.md |
Documents the new API. |
packages/react/src/index.stories.tsx |
Deduplicates style renderer registration. |
packages/react/src/canvas/CanvasController-Template.stories.tsx |
Deduplicates root renderer registration. |
packages/react/src/canvas/CanvasScopeMolecule.tsx |
Implements registerOnce. |
packages/react/src/canvas/CanvasScopeMolecule.test.tsx |
Tests registration counts. |
packages/react/src/canvas/plugins/CanvasHoveredMolecule.ts |
Groups hover registrations. |
packages/react/src/canvas/plugins/CanvasPickAndPlopMolecule.tsx |
Groups pick-and-plop registrations. |
packages/react/src/canvas/plugins/CanvasSelectionMolecule.tsx |
Groups selection registrations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AndiLuo
approved these changes
Oct 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description of the change
Type of change
Links
Checklists
Development
Paperwork
Code review