Fix: avoid modifying element in Web Component constructor to comply w…#39
Open
telephant wants to merge 1 commit intoryansolid:masterfrom
Open
Fix: avoid modifying element in Web Component constructor to comply w…#39telephant wants to merge 1 commit intoryansolid:masterfrom
telephant wants to merge 1 commit intoryansolid:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Web Components specification, the constructor of a custom element must not modify the element — for example, by adding attributes, child elements, or own properties that trigger internal checks.
Fix
Result
This change ensures the custom element conforms to the Web Components spec and avoids NotSupportedError in browsers.