Skip to content

next: avoids transforming case and dashes for attributes/properties#32

Draft
titoBouzout wants to merge 1 commit intoryansolid:masterfrom
titoBouzout:master
Draft

next: avoids transforming case and dashes for attributes/properties#32
titoBouzout wants to merge 1 commit intoryansolid:masterfrom
titoBouzout:master

Conversation

@titoBouzout
Copy link
Copy Markdown

@titoBouzout titoBouzout commented Mar 9, 2025

Related to ryansolid/dom-expressions#373

We avoid transforming attributes to lowercase and also transforming dashed-case to camelCase

Note:

  • toAttribute and toProperty are no longer exported, I am not sure if this affects other packages?
  • src/index.ts had windows line endings, I tried to keep it like that but editor insisted on changing to unix line endings so well, this link shows the diff without the whitespace change https://github.com/ryansolid/component-register/pull/32/files?w=1

@ryansolid
Copy link
Copy Markdown
Owner

ryansolid commented Mar 9, 2025

Should we care about decisions in DOm Expressions here? What I mean is it is a good thing to reflect where we can and having an automatic heuristic helps authoring. It can be overriden to use whatever attribute name you want. But in absence it does something reasonable perhaps?

It's one thing for Dom Expressions to expect a certain convention on consuming any web components, versus this setting a default for authoring.

@titoBouzout
Copy link
Copy Markdown
Author

Makes sense, one project should probably not limit the other, specially when used by choice.

To make a formed opinion, I will have to research how is being used, so marking it as draft meanwhile. I'm trying to be consistent and worry about having two conventions. I will see, thanks!

@titoBouzout titoBouzout marked this pull request as draft March 10, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants