next: avoids transforming case and dashes for attributes/properties#32
Draft
titoBouzout wants to merge 1 commit intoryansolid:masterfrom
Draft
next: avoids transforming case and dashes for attributes/properties#32titoBouzout wants to merge 1 commit intoryansolid:masterfrom
titoBouzout wants to merge 1 commit intoryansolid:masterfrom
Conversation
Owner
|
Should we care about decisions in DOm Expressions here? What I mean is it is a good thing to reflect where we can and having an automatic heuristic helps authoring. It can be overriden to use whatever attribute name you want. But in absence it does something reasonable perhaps? It's one thing for Dom Expressions to expect a certain convention on consuming any web components, versus this setting a default for authoring. |
Author
|
Makes sense, one project should probably not limit the other, specially when used by choice. To make a formed opinion, I will have to research how is being used, so marking it as draft meanwhile. I'm trying to be consistent and worry about having two conventions. I will see, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ryansolid/dom-expressions#373
We avoid transforming attributes to lowercase and also transforming
dashed-casetocamelCaseNote:
toAttributeandtoPropertyare no longer exported, I am not sure if this affects other packages?src/index.tshad windows line endings, I tried to keep it like that but editor insisted on changing to unix line endings so well, this link shows the diff without the whitespace change https://github.com/ryansolid/component-register/pull/32/files?w=1