Skip to content

Adding fused div_add#149

Open
PaulXiCao wants to merge 11 commits intorust-num:masterfrom
PaulXiCao:iss-146-div_add
Open

Adding fused div_add#149
PaulXiCao wants to merge 11 commits intorust-num:masterfrom
PaulXiCao:iss-146-div_add

Conversation

@PaulXiCao
Copy link
Copy Markdown

@PaulXiCao PaulXiCao commented Oct 25, 2025

Closes #146 .

This adds functions div_add and trait DivAdd. Tests are also added.

@redweasel
Copy link
Copy Markdown

Similar to the mul_add case you are testing against the "less precisely rounded version" and checking for equality. If those test succeed that means your implementation is just as precise as the default and you don't benefit from fma precision. Can you do a performance comparison to show in numbers, that fma is worth it? https://accurate-algorithms.readthedocs.io/en/latest/ch03fma.html suggests, that it has the same performance whilst theoretically achieving better precision if used right (not used right here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: Add fma_{mul,div} for FMA-based complex operations

2 participants