Open
Conversation
MarijnS95
reviewed
Jan 3, 2025
xcommon/Cargo.toml
Outdated
| byteorder = "1.4.3" | ||
| dunce = "1" | ||
| image = { version = "0.24.5", default-features = false, features = ["png", "webp"] } | ||
| image = { version = "0.25.5", default-features = false, features = ["png", "webp"] } |
Member
There was a problem hiding this comment.
I'd love to see if 0.25.0 would work equally well :)
Author
There was a problem hiding this comment.
Sadly, it doesn't. But 0.25.2 does.
Only imports within the same module share a line.
MarijnS95
approved these changes
Jan 6, 2025
Member
MarijnS95
left a comment
MarijnS95
left a comment
There was a problem hiding this comment.
I'll accept and merge this for now, but want to have -Zminimal-version CI checking in place before incorporating any other upgrades.
Member
|
Likewise we need to have an MSRV policy. This dependency bumps from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the image crate and updates the code for incompatible changes