Skip to content

Remove T-libs-api labels from code - #2474

Merged
Urgau merged 1 commit into
rust-lang:masterfrom
clarfonthey:libs-api
Aug 12, 2026
Merged

Remove T-libs-api labels from code#2474
Urgau merged 1 commit into
rust-lang:masterfrom
clarfonthey:libs-api

Conversation

@clarfonthey

Copy link
Copy Markdown
Contributor

Part of RFC 3984. Most of these don't actually matter, but I figured it's good to just remove mentions of T-libs-api from code for completeness so we can just grep for libs-api to make sure it's not being added to things.

In most cases, T-libs is added anyway as a precaution, but I figure we want to try and centralise on one label.

@Urgau

Urgau commented Aug 12, 2026

Copy link
Copy Markdown
Member

make sure it's not being added to things

All of the references here are in the compiler agenda generator, which doesn't add any labels.


Regarding the change it-self, I can still see 30 PRs with the label, some of which without T-libs, so this may regress some queries by not excluding some issues.

cc @apiraino

@clarfonthey

clarfonthey commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Note: I'm also currently working on fixing that as we speak, FWIW. Just takes a while to run a script with API limits and such. Also, I was under the impression the backporting here is actually the only place in the entire org where the labels are actually added to things, and that is outside the agenda generator.

@Urgau

Urgau commented Aug 12, 2026

Copy link
Copy Markdown
Member

Also, I was under the impression the backporting here is actually the only place in the entire org where the labels are actually added to things

The one you modified are in our unit tests, they don't do anything, unless you are talking about another place.

@clarfonthey

Copy link
Copy Markdown
Contributor Author

Wow, you are actually right there. This is what I get for not reading closely.

@Urgau Urgau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked that the label is no longer in-used in any of the repo the agenda referenced.

The rest looks good to me as well.

View changes since this review

@Urgau
Urgau added this pull request to the merge queue Aug 12, 2026
Merged via the queue into rust-lang:master with commit b1f0c2a Aug 12, 2026
3 checks passed
@clarfonthey
clarfonthey deleted the libs-api branch August 12, 2026 19:46
@apiraino

Copy link
Copy Markdown
Contributor

nice, thanks for doing the work for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants