Add perf triage for 2026-07-06#2492
Merged
Merged
Conversation
panstromek
commented
Jul 6, 2026
Comment on lines
+42
to
+43
| Use `LowerAvailableDepth::No` for normalizes-to goal itself instead of its nested goals [#158705](https://github.com/rust-lang/rust/pull/158705) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3659db0d3e2cd634c766fcda79ed118eca31a9fd&end=3c00c96d3af4d5b5e101e56cc161a608b21366ee&stat=instructions:u) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
There's something weird going on. Base commit of this PR is the end commit of the summary range. It looks like summary range "forgets" the last commit during generation. Even if I specify it explicitly in the url, it will silently only include the one before.
I think this is the same issue as #1599. I think that that bug will happen if the last commit in range has significant changes, so next triage will reproduce it, I believe.
I suspect we do something suspicious when iterating over commits, but I tried to stare at the main loop in handle_triage for an hour and I couldn't figure out whether it's right or not, it is quite confusing 😄
nnethercote
reviewed
Jul 6, 2026
nnethercote
approved these changes
Jul 6, 2026
Co-authored-by: Nicholas Nethercote <n.nethercote@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.