derive(Diagnostic): #[note] etc also work on bool fields - #2955
Open
RalfJung wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least it certainly looks like this works:
https://github.com/rust-lang/rust/blob/c82207c46e5cefe4ddb000232aec281c28f0f6a8/compiler/rustc_codegen_ssa/src/diagnostics.rs#L1240-L1246
and then I assume it works for all of them, not just
#[note].There are also more attributes the docs don't mention:
help_once,note_once. I'm not sure what exactly those do. They were added in rust-lang/rust#124417. Cc @Xiretza @fmaese