-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Upgrade and deduplicate dependencies #160529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,8 +15,8 @@ fn main() { | |
| for payload in wasmparser::Parser::new(0).parse_all(&file) { | ||
| let payload = payload.unwrap(); | ||
| if let wasmparser::Payload::ImportSection(s) = payload { | ||
| for i in s { | ||
| let i = i.unwrap(); | ||
| for i in s.into_iter().flat_map(Result::unwrap) { | ||
| let (_, i) = i.unwrap(); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this wants https://docs.rs/wasmparser/latest/wasmparser/type.ImportSectionReader.html#method.into_imports? Not quite sure what the flat_map is flattening - is that an iterator or an option? Not sure if we're on latest wasmparser... |
||
| imports.entry(i.module).or_insert(Vec::new()).push((i.name, i.ty)); | ||
| } | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| error: couldn't load codegen backend /non-existing-one.so: cannot open shared object file: No such file or directory | ||
| error: couldn't load codegen backend /non-existing-one.so: dlopen failed: /non-existing-one.so: cannot open shared object file: No such file or directory | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the failures here are:
(https://docs.rs/object/latest/object/write/elf/struct.Encoder.html#method.dynamic)
Not sure if those can happen for user reasons, but I guess either way this is just an ICE so seems OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
DT_tags are definitely inu32range. If thissonameoffset orverdef_countare out of range, the whole file is probably too big for 32-bit. Either way, the old version ofobjectjust castedas u32, which would be silent corruption, so I guess an ICE is better.