Do not run tests in dist jobs

[Kobzol]

We found out in #159455 that some dist jobs run tests, but this seems as a historical artifact (going way back to <2020).

These targets are tier 2 or tier 3 anyway, and shouldn't run tests, much less so in dist jobs.

r? @jieyouxu

[jieyouxu]

Thanks. If tests were to be run for these tier 2-ish targets, they ought to be non dist-* jobs 👍

@bors r+ rollup=never (changes CI job defs)

View changes since this review

[jieyouxu]

Remark: this always tripped me up yeah

[rust-bors]

📌 Commit a90b6ec has been approved by jieyouxu

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

Reason for tree closure: spurious failures

[jhpratt]

@bors p=100 running with tree closed

[rust-bors]

☀️ Test successful - CI
Approved by: jieyouxu
Duration: 3h 42m 19s
Pushing bf9944f to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d3ea035 (parent) -> bf9944f (this PR)

Test differences

Show 40981 test diffs

Stage 2

• [assembly] tests/assembly-llvm/targets/targets-elf.rs#armv6_none_eabihf: pass -> [missing] (J0)
• [assembly] tests/assembly-llvm/targets/targets-elf.rs#armv6_unknown_freebsd: pass -> [missing] (J0)
• [assembly] tests/assembly-llvm/targets/targets-elf.rs#x86_64_pc_qnx: pass -> [missing] (J0)
• [codegen] tests/codegen-llvm/asm/critical.rs: ignore (only executed when the architecture is x86_64) -> [missing] (J0)
• [codegen] tests/codegen-llvm/cf-protection.rs#return_: pass -> [missing] (J0)
• [crashes] tests/crashes/reborrow/corrected-field-mismatch-coerce-shared-issue-156315.rs: pass -> [missing] (J0)
• [debuginfo-gdb] tests/debuginfo/msvc-pretty-enums.rs: ignore (gdb is not available) -> [missing] (J0)
• [incremental] tests/incremental/env/env_macro.rs: pass -> [missing] (J0)
• [run-make] tests/run-make/resolve-rename: pass -> [missing] (J0)
• [ui] tests/ui/asm/const-refs-to-static.rs: pass -> [missing] (J0)
• [ui] tests/ui/asm/issue-99122-2.rs: ignore (only executed when the architecture is x86_64) -> [missing] (J0)
• [ui] tests/ui/attributes/crate-type-macro-empty.rs: pass -> [missing] (J0)
• [ui] tests/ui/autoref-autoderef/auto-ref-bounded-ty-param.rs: pass -> [missing] (J0)
• [ui] tests/ui/borrowck/borrowed-data-escapes-closure-148392.rs: pass -> [missing] (J0)
• [ui] tests/ui/borrowck/issue-45983.rs: pass -> [missing] (J0)
• [ui] tests/ui/cfg/cfg_target_object_format.rs#bpfeb: pass -> [missing] (J0)
• [ui] tests/ui/closures/2229_closure_analysis/array_subslice.rs: pass -> [missing] (J0)
• [ui] tests/ui/codegen/equal-pointers-unequal/as-cast/inline2.rs: pass -> [missing] (J0)
• [ui] tests/ui/codegen/normalization-overflow/recursion-issue-95134.rs: pass -> [missing] (J0)
• [ui] tests/ui/coherence/orphan-check-weak-aliases-not-covering.rs: pass -> [missing] (J0)
• [ui] tests/ui/const-generics/associated-const-bindings/esc-bound-var-in-ty.rs: pass -> [missing] (J0)
• [ui] tests/ui/const-generics/generic_const_exprs/double-opaque-parent-predicates.rs: pass -> [missing] (J0)
• [ui] tests/ui/const-generics/mgca/selftyalias-containing-param.rs: pass -> [missing] (J0)
• [ui] tests/ui/const-generics/mgca/type_const-mismatched-types.rs: pass -> [missing] (J0)
• [ui] tests/ui/const-ptr/pointer-address-stability.rs: pass -> [missing] (J0)
• [ui] tests/ui/const_prop/unreachable-overflow.rs: pass -> [missing] (J0)
• [ui] tests/ui/consts/const-fn-method.rs: pass -> [missing] (J0)
• [ui] tests/ui/contracts/contracts-requires-is-not-inherited-when-nesting.rs: pass -> [missing] (J0)
• [ui] tests/ui/coroutine/delayed-obligations-emit.rs#current: pass -> [missing] (J0)
• [ui] tests/ui/derives/eq-ord/deriving-cmp-shortcircuit.rs: pass -> [missing] (J0)
• [ui] tests/ui/dropck/coroutine-liveness-2.rs: pass -> [missing] (J0)
• [ui] tests/ui/error-codes/E0276.rs: pass -> [missing] (J0)
• [ui] tests/ui/error-codes/E0464.rs: pass -> [missing] (J0)
• [ui] tests/ui/error-codes/E0800.rs: pass -> [missing] (J0)
• [ui] tests/ui/ffi-attrs/ffi_const2.rs: pass -> [missing] (J0)
• [ui] tests/ui/fn/fn-arg-count-mismatch-diagnostics.rs: pass -> [missing] (J0)
• [ui] tests/ui/fn/fn-trait-use-named-params-issue-140169.rs: pass -> [missing] (J0)
• [ui] tests/ui/fn/param-mismatch-trait-fn.rs: pass -> [missing] (J0)
• [ui] tests/ui/generics/generic-struct-self-unconstrained-inference-vars-69306.rs: pass -> [missing] (J0)
• [ui] tests/ui/imports/issue-28134.rs: pass -> [missing] (J0)
• [ui] tests/ui/layout/issue-60431-unsized-tail-behind-projection.rs: pass -> [missing] (J0)
• [ui] tests/ui/linkage-attr/linkage2.rs: pass -> [missing] (J0)
• [ui] tests/ui/lint/dead-code/inferred-generic-arg.rs: pass -> [missing] (J0)
• [ui] tests/ui/lint/non-snake-case/lint-non-snake-case-no-lowercase-equivalent.rs: pass -> [missing] (J0)
• [ui] tests/ui/lint/unused/unused-parens-for-stmt-expr-attributes-issue-129833.rs: pass -> [missing] (J0)
• [ui] tests/ui/macros/macro-expansion-tests.rs: pass -> [missing] (J0)
• [ui] tests/ui/mir/const_eval_select_cycle.rs: pass -> [missing] (J0)
• [ui] tests/ui/never_type/regress/never-type-fallback-option.rs: pass -> [missing] (J0)
• [ui] tests/ui/nll/issue-52059-report-when-borrow-and-drop-conflict.rs: pass -> [missing] (J0)
• [ui] tests/ui/parser/diff-markers/unclosed-delims.rs: pass -> [missing] (J0)
• [ui] tests/ui/parser/issues/issue-48636.rs: pass -> [missing] (J0)
• [ui] tests/ui/parser/keyword-where-as-identifier.rs: pass -> [missing] (J0)
• [ui] tests/ui/parser/lifetime-semicolon.rs: pass -> [missing] (J0)
• [ui] tests/ui/recursion/recursion-tail-call-no-arg-leak.rs: pass -> [missing] (J0)
• [ui] tests/ui/regions/regions-early-bound-used-in-bound-method.rs: pass -> [missing] (J0)
• [ui] tests/ui/regions/regions-free-region-ordering-callee-4.rs: pass -> [missing] (J0)
• [ui] tests/ui/regions/regions-infer-call-2.rs: pass -> [missing] (J0)
• [ui] tests/ui/self/elision/struct-async.rs: pass -> [missing] (J0)
• [ui] tests/ui/shadowed/shadow-unit-struct-in-closure.rs: pass -> [missing] (J0)
• [ui] tests/ui/specialization/min_specialization/specialization_trait.rs: pass -> [missing] (J0)
• [ui] tests/ui/stability-attribute/stability-attribute-sanity.rs: pass -> [missing] (J0)
• [ui] tests/ui/statics/issue-17718-static-sync.rs: pass -> [missing] (J0)
• [ui] tests/ui/suggestions/suggest-full-enum-variant-for-local-module.rs: pass -> [missing] (J0)
• [ui] tests/ui/symbol-names/x86-stdcall.rs: ignore (only executed when the operating system is windows) -> [missing] (J0)
• [ui] tests/ui/target-feature/missing-plusminus.rs: pass -> [missing] (J0)
• [ui] tests/ui/test-attrs/custom_test_frameworks_simple.rs: pass -> [missing] (J0)
• [ui] tests/ui/traits/alias/impl.rs: pass -> [missing] (J0)
• [ui] tests/ui/traits/const-traits/const-closure-in-non-const-trait-impl-method.rs: pass -> [missing] (J0)
• [ui] tests/ui/traits/const-traits/double-error-for-unimplemented-trait.rs: pass -> [missing] (J0)
• [ui] tests/ui/traits/default-method/rustc_must_implement_one_of_duplicates.rs: pass -> [missing] (J0)
• [ui] tests/ui/type-alias-impl-trait/generic_duplicate_param_use4.rs: pass -> [missing] (J0)
• [ui] tests/ui/type-alias-impl-trait/impl-trait-in-type-alias-with-bad-substs.rs: pass -> [missing] (J0)
• [ui] tests/ui/typeck/osstring-str-equality.rs: pass -> [missing] (J0)
• [ui] tests/ui/typeck/return-dyn-type-mismatch-2.rs: pass -> [missing] (J0)
• [ui] tests/ui/unboxed-closures/unboxed-closures-infer-arg-types-w-bound-regs-from-expected-bound.rs: pass -> [missing] (J0)
• [ui] tests/ui/where-clauses/projection-bound-unsatisfied-item-bounds-mit-opt-ice.rs: pass -> [missing] (J0)
• collections::btree::map::tests::test_merge_conflict_drop_leak: pass -> [missing] (J0)
• collections::btree::set::tests::test_extract_if_pred_panic_leak: pass -> [missing] (J0)
• fmt::builders::debug_list::test_nested_non_exhaustive: pass -> [missing] (J0)
• fmt::test_write: pass -> [missing] (J0)
• io::buffered::tests::test_buffered_writer_seek: pass -> [missing] (J0)
• io::io_slice::io_slice_into_slice: pass -> [missing] (J0)
• mpsc::oneshot_single_thread_try_send_closed: pass -> [missing] (J0)
• num::cast::test_checked_cast_i8_to_u8: pass -> [missing] (J0)
• num::floats::to_degrees::test_f64: pass -> [missing] (J0)
• num::i128::test_saturating_abs: pass -> [missing] (J0)
• num::int_bits::u64::invariant::deposit_bits: pass -> [missing] (J0)
• num::int_bits::u64::variable::deposit_bits: pass -> [missing] (J0)
• num::u128::test_le: pass -> [missing] (J0)
• once_lock::sync_once_cell_get_mut: pass -> [missing] (J0)
• rwlock::poison_test_rw_arc_access_in_unwind: pass -> [missing] (J0)
• slice::slice_index::assert_range_eq_can_fail_by_inequality: pass -> [missing] (J0)
• sort::tests::stable::panic_retain_orig_set_cell_i32_descending: pass -> [missing] (J0)
• sort::tests::stable::stability_legacy: pass -> [missing] (J0)
• str::pattern::str_searcher_empty_needle_empty_haystack::fwd: pass -> [missing] (J0)
• str::test_copy_from_str_unequal_len: pass -> [missing] (J0)
• task::poll_const: pass -> [missing] (J0)
• thread::tests::test_unnamed_thread: pass -> [missing] (J0)
• vec::bench_dedup_all_1000: pass -> [missing] (J0)
• [run-make] tests/run-make/pgo-gen: ignore (ignored when cross-compiling) -> [missing] (J1)

(and 32396 additional test diffs)

Additionally, 8485 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: dist-i586-gnu-i586-i686-musl
• J1: dist-i586-gnu-i586-i686-musl, dist-various-1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard bf9944f0b8006b152ef4d5f408ae75a0dde3d044 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-i586-gnu-i586-i686-musl: 1h 31m -> 13m 45s (-84.9%)
2. x86_64-mingw-2: 1h 49m -> 2h 44m (+50.9%)
3. dist-various-1: 1h 17m -> 41m 7s (-46.8%)
4. x86_64-msvc-ext3: 1h 21m -> 1h 53m (+39.8%)
5. dist-arm-linux-musl: 1h 45m -> 1h 4m (-39.0%)
6. dist-x86_64-msvc-alt: 2h 8m -> 2h 57m (+37.9%)
7. x86_64-gnu-llvm-22-2: 1h 12m -> 1h 38m (+36.4%)
8. dist-android: 28m 52s -> 20m 16s (-29.8%)
9. x86_64-gnu-next-trait-solver-polonius: 48m 51s -> 1h 2m (+27.7%)
10. x86_64-gnu-gcc-core-tests: 10m 47s -> 13m 46s (+27.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (bf9944f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 11.1%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	11.1%	[11.1%, 11.1%]	1
Regressions ❌ (secondary)	3.7%	[1.2%, 6.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.2%	[-6.1%, -2.2%]	2
All ❌✅ (primary)	11.1%	[11.1%, 11.1%]	1

Cycles

Results (secondary -4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.3%	[-4.7%, -4.0%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 487.844s -> 487.856s (0.00%)
Artifact size: 388.73 MiB -> 388.05 MiB (-0.17%)