Fix find_attr hygiene and rustc_hir cleanups#159893
Open
mejrs wants to merge 4 commits into
Open
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_hir/src/attrs |
rustbot
added
A-attributes
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JonathanBrouwer
approved these changes
Jul 25, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. |
Contributor
Author
|
Pushed some additional small commits (not just fix to doclinks) |
This comment has been minimized.
This comment has been minimized.
mejrs
changed the title
find_attr hygiene and remove extern crate self as rustc_hir;find_attr hygiene and rustc_hir cleanups
Collaborator
|
cc @rust-lang/clippy |
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
JonathanBrouwer
approved these changes
Jul 25, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 25, 2026
…nBrouwer Fix `find_attr` hygiene and `rustc_hir` cleanups In particular, `extern crate self as rustc_hir;` leads to very noisy import suggestions if you get an import wrong. Also flatten the `nested_filter` module which seemed to exist just to avoid `None` / `Option:None` nameres conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular,
extern crate self as rustc_hir;leads to very noisy import suggestions if you get an import wrong. Also flatten thenested_filtermodule which seemed to exist just to avoidNone/Option:Nonenameres conflicts