semicolon_in_expressions_from_macros: Lint on non-local macros too by joshtriplett · Pull Request #159222 · rust-lang/rust

joshtriplett · 2026-07-13T12:47:17Z

The semicolon_in_expressions_from_macros lint previously suppressed
warnings about non-local macros. This masks a lint that will
subsequently become a hard error.

Stop suppressing it, dropping the is_local flag and check.

Fix the test for this case to now expect the error. Drop a separate test
that depended on the lack of error (and that specifically notes it
should be dropped once the lint becomes a hard error).

The `semicolon_in_expressions_from_macros` lint previously suppressed warnings about non-local macros. This masks a lint that will subsequently become a hard error. Stop suppressing it, dropping the `is_local` flag and check. Fix the test for this case to now expect the error. Drop a separate test that depended on the lack of error (and that specifically notes it should be dropped once the lint becomes a hard error).

rustbot · 2026-07-13T12:47:22Z

r? @hanna-kruppe

rustbot has assigned @hanna-kruppe.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 18 candidates

petrochenkov · 2026-07-13T12:52:17Z

@bors r+

rust-bors · 2026-07-13T12:52:19Z

📌 Commit 9192337 has been approved by petrochenkov

It is now in the queue for this repository.

Urgau · 2026-07-13T13:29:30Z

Probably deserves to be on the releases notes.

@rustbot label +relnotes

semicolon_in_expressions_from_macros: Lint on non-local macros too The `semicolon_in_expressions_from_macros` lint previously suppressed warnings about non-local macros. This masks a lint that will subsequently become a hard error. Stop suppressing it, dropping the `is_local` flag and check. Fix the test for this case to now expect the error. Drop a separate test that depended on the lack of error (and that specifically notes it should be dropped once the lint becomes a hard error).

…uwer Rollup of 13 pull requests Successful merges: - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #157706 (Deny `todo!()` in tidy) - #156712 (Pointer authentication config and user facing options) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too) - #156609 (Consider structurally impossible Sized predicates in MIR) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

semicolon_in_expressions_from_macros: Lint on non-local macros too The `semicolon_in_expressions_from_macros` lint previously suppressed warnings about non-local macros. This masks a lint that will subsequently become a hard error. Stop suppressing it, dropping the `is_local` flag and check. Fix the test for this case to now expect the error. Drop a separate test that depended on the lack of error (and that specifically notes it should be dropped once the lint becomes a hard error).

…uwer Rollup of 14 pull requests Successful merges: - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #157706 (Deny `todo!()` in tidy) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #158846 (Fix unused variable warnings for diverging expressions) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too) - #156609 (Consider structurally impossible Sized predicates in MIR) - #157993 (Expose more info about ADTs and functions in rustc_public) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

JonathanBrouwer · 2026-07-13T17:00:11Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: https://productionresultssa7.blob.core.windows.net/actions-results/06bc32af-c7d1-4940-bb81-ba98a65b020e/workflow-job-run-f35fa0ed-923a-5c7b-a71c-de67c7fa0923/logs/job/job-logs.txt?rsct=text%2Fplain&se=2026-07-13T17%3A07%3A00Z&sig=qiTACPaqBZaMDYmvTfkJk2YnjYEJqnMZJdAxBdQkcSc%3D&ske=2026-07-13T19%3A40%3A18Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2026-07-13T15%3A40%3A18Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2026-07-13T16%3A56%3A55Z&sv=2025-11-05

rust-bors · 2026-07-13T17:00:20Z

This pull request was unapproved.

This PR was contained in a rollup (#159236), which was unapproved.

View changes since this unapproval

joshtriplett · 2026-07-13T21:18:25Z

I wasn't expecting this to get r+ed and get pulled into rollups before it passed CI. I'll work on fixing the failures.

semicolon_in_expressions_from_macros: Lint on non-local macros too try-job: test-various

rust-bors · 2026-07-15T00:55:44Z

☀️ Try build successful (CI)
Build commit: 2b850d5 (2b850d5dbbf142fe9af6c1cf3347eee31bb3bf63)
Base parent: da80ed0 (da80ed0708a09dc096c184345d6eb42cbcd50a1e)

joshtriplett · 2026-07-15T03:47:09Z

@rustbot ready

petrochenkov · 2026-07-15T10:26:58Z

@bors r+

rust-bors · 2026-07-15T10:27:01Z

📌 Commit aa53fee has been approved by petrochenkov

It is now in the queue for this repository.

…uwer Rollup of 8 pull requests Successful merges: - #159197 (Rename ModDefId to ModId and use more) - #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too) - #159296 (Implement `bool::toggle`) - #158302 (Fix `overflowing_literals` lint with repeated negation) - #158484 (Add documentation for the `cold` and `track_caller` attributes) - #159239 (Add codegen test for remainder match) - #159330 (fix some edition annotations in UI tests) - #159331 (Fix ignore-llvm-version directive in codegen-llvm/array-equality.rs) Failed merges: - #158962 (Add `proc_macro` attribute documentation)

Rollup merge of #159222 - joshtriplett:main, r=petrochenkov semicolon_in_expressions_from_macros: Lint on non-local macros too The `semicolon_in_expressions_from_macros` lint previously suppressed warnings about non-local macros. This masks a lint that will subsequently become a hard error. Stop suppressing it, dropping the `is_local` flag and check. Fix the test for this case to now expect the error. Drop a separate test that depended on the lack of error (and that specifically notes it should be dropped once the lint becomes a hard error).

These macros are used like expressions, so they should not emit a semicolon. This is being turned into a hard error in a future release of Rust. error: trailing semicolon in macro used in expression position --> drivers/gpu/nova-core/firmware/fsp.rs:79:34 | 79 | .inspect_err(|_| dev_err!(dev, "FMC firmware missing '{}' section\n", name)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #79813 <rust-lang/rust#79813> = note: this error originates in the macro `dev_err` (in Nightly builds, run with -Z macro-backtrace for more info) [ I was doubly surprised since upstream made it a deny-by-default lint a year ago for Rust 1.91.0, and yet we didn't see it; plus I hadn't seen this in my CI even yesterday. It turns out this just landed into today's nightly (nightly-2026-07-16, using upstream commit d0babd8b6): Link: rust-lang/rust#159222 which says: "The `semicolon_in_expressions_from_macros` lint previously suppressed warnings about non-local macros. This masks a lint that will subsequently become a hard error." So that explains it. And this is the PR that will make it a hard error at some point in the future: Link: rust-lang/rust#159218 Thus starting with Rust 1.99.0 (expected 2026-10-01), we will be seeing the deny-by-default lint above, so clean it up already. - Miguel ] Cc: stable@vger.kernel.org # Needed in 6.18.y and later. Link: rust-lang/rust#79813 Signed-off-by: Alice Ryhl <aliceryhl@google.com> Reviewed-by: Gary Guo <gary@garyguo.net> Link: rust-lang/rust#159218 Link: rust-lang/rust#159222 Link: https://patch.msgid.link/20260716-device-trail-semicolon-v1-1-f48e9dcfae15@google.com [ Fixed typo. ] Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

ehuss · 2026-07-16T17:42:33Z

Just FYI, this is hitting popular crates like nix, which do not have a fix or new version published. Normally we try to not add warnings with popular dependencies that the user cannot update.

ehuss · 2026-07-16T17:44:30Z

(Interestingly, the reports are blaming nix, but the actual issue is in the cfg_aliases crate.)

The latest nightly has started to warn that `nix` will break in the future due to `semicolon_in_expressions_from_macros`. The actual issue is related to `cfg_aliases`, which was affected by rust-lang/rust#159222.

These macros are used like expressions, so they should not emit a semicolon. This is being turned into a hard error in a future release of Rust. error: trailing semicolon in macro used in expression position --> drivers/gpu/nova-core/firmware/fsp.rs:79:34 | 79 | .inspect_err(|_| dev_err!(dev, "FMC firmware missing '{}' section\n", name)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #79813 <rust-lang/rust#79813> = note: this error originates in the macro `dev_err` (in Nightly builds, run with -Z macro-backtrace for more info) [ I was doubly surprised since upstream made it a deny-by-default lint a year ago for Rust 1.91.0, and yet we didn't see it; plus I hadn't seen this in my CI even yesterday. It turns out this just landed into today's nightly (nightly-2026-07-16, using upstream commit d0babd8b6): Link: rust-lang/rust#159222 which says: "The `semicolon_in_expressions_from_macros` lint previously suppressed warnings about non-local macros. This masks a lint that will subsequently become a hard error." So that explains it. And this is the PR that will make it a hard error at some point in the future: Link: rust-lang/rust#159218 Thus starting with Rust 1.99.0 (expected 2026-10-01), we will be seeing the deny-by-default lint above, so clean it up already. - Miguel ] Cc: stable@vger.kernel.org # Needed in 6.18.y and later. Link: rust-lang/rust#79813 Signed-off-by: Alice Ryhl <aliceryhl@google.com> Reviewed-by: Gary Guo <gary@garyguo.net> Acked-by: Danilo Krummrich <dakr@kernel.org> Link: rust-lang/rust#159218 Link: rust-lang/rust#159222 Link: https://patch.msgid.link/20260716-device-trail-semicolon-v1-1-f48e9dcfae15@google.com [ Fixed typo. ] Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

joshtriplett · 2026-07-20T04:43:31Z

@ehuss wrote:

Just FYI, this is hitting popular crates like nix, which do not have a fix or new version published. Normally we try to not add warnings with popular dependencies that the user cannot update.

Yeah, we probably shouldn't take the existing FCW as precedent, since it hasn't been warning about the non-local case. If there are more widespread issues, it may make sense to separate the non-local case into a separate warning and start that one off as warn-by-default.

joshtriplett · 2026-07-22T06:56:10Z

#159700

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2026

rustbot assigned hanna-kruppe Jul 13, 2026

joshtriplett assigned petrochenkov and unassigned hanna-kruppe Jul 13, 2026

joshtriplett mentioned this pull request Jul 13, 2026

Make semicolon_in_expressions_from_macros a hard error #159218

Open

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2026

rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 13, 2026

rustbot mentioned this pull request Jul 13, 2026

Tracking issue for release notes of #159222: semicolon_in_expressions_from_macros: Lint on non-local macros too #159223

Open

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 13 pull requests #159231

Closed

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 14 pull requests #159236

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2026

rust-bors Bot pushed a commit that referenced this pull request Jul 14, 2026

Auto merge of #159222 - joshtriplett:main, r=<try>

2b850d5

semicolon_in_expressions_from_macros: Lint on non-local macros too try-job: test-various

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2026

JonathanBrouwer mentioned this pull request Jul 15, 2026

Rollup of 8 pull requests #159336

Merged

rust-bors Bot merged commit ac05d38 into rust-lang:main Jul 15, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 15, 2026

nazar-pc mentioned this pull request Jul 16, 2026

Fix trailing semicolon in expression macro bodies katharostech/cfg_aliases#15

Merged

George-Miao mentioned this pull request Jul 16, 2026

fix: semicolon_in_expressions_from_macros compio-rs/compio#977

Merged

jieyouxu mentioned this pull request Jul 16, 2026

tests/debuginfo/function-call.rs + gdb is flaky #159073

Open

ehuss mentioned this pull request Jul 16, 2026

Update cfg_aliases to 0.2.2 rust-lang/cargo#17225

Merged

afishhh mentioned this pull request Jul 17, 2026

Fix trailing semicolon in expression from make_static_outline macro afishhh/subrandr#186

Merged

nazar-pc mentioned this pull request Jul 18, 2026

Fix trailing semicolon in expression macro bodies paritytech/parity-common#980

Open

Uh oh!

Uh oh!

Conversation

joshtriplett commented Jul 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 13, 2026

Uh oh!

petrochenkov commented Jul 13, 2026

Uh oh!

rust-bors Bot commented Jul 13, 2026

Uh oh!

Urgau commented Jul 13, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Jul 13, 2026

Uh oh!

rust-bors Bot commented Jul 13, 2026

Uh oh!

joshtriplett commented Jul 13, 2026

Uh oh!

rust-bors Bot commented Jul 15, 2026

Uh oh!

joshtriplett commented Jul 15, 2026

Uh oh!

petrochenkov commented Jul 15, 2026

Uh oh!

rust-bors Bot commented Jul 15, 2026

Uh oh!

Uh oh!

ehuss commented Jul 16, 2026

Uh oh!

ehuss commented Jul 16, 2026

Uh oh!

joshtriplett commented Jul 20, 2026

Uh oh!

joshtriplett commented Jul 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

joshtriplett commented Jul 13, 2026 •

edited by rustbot

Loading