Skip to content

fix: Lower range expressions in hir lowering - #23115

Merged
Veykril merged 1 commit into
rust-lang:masterfrom
ChayimFriedman2:lower-range
Aug 13, 2026
Merged

fix: Lower range expressions in hir lowering#23115
Veykril merged 1 commit into
rust-lang:masterfrom
ChayimFriedman2:lower-range

Conversation

@ChayimFriedman2

Copy link
Copy Markdown
Contributor

And remove them from the HIR. rustc does the same, and we have no reason to do differently.

Fixes #23113.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2026

@Wilfred Wilfred left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice simplification :)

View changes since this review

@rustbot

This comment has been minimized.

And remove them from the HIR. rustc does the same, and we have no reason to do differently.
@rustbot

rustbot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Veykril
Veykril added this pull request to the merge queue Aug 13, 2026
Merged via the queue into rust-lang:master with commit bc990e8 Aug 13, 2026
18 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2026
@ChayimFriedman2
ChayimFriedman2 deleted the lower-range branch August 13, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FP expected i32, found / the trait bound !: Step is not satisfied : for i in 0..loop {} {}

4 participants