fix: give impl_trait_with_diagnostics a cycle result#22923
Merged
ChayimFriedman2 merged 1 commit intoJul 26, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
Jul 26, 2026
shulaoda
force-pushed
the
07-26-fix_give_impl_trait_with_diagnostics_a_cycle_result
branch
from
July 26, 2026 16:35
5daa7a0 to
320e379
Compare
ChayimFriedman2
approved these changes
Jul 26, 2026
ChayimFriedman2
enabled auto-merge
July 26, 2026 16:38
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22795
impl Self::Selfmakes the impl's trait ref depend on its own self type, and salsa panics becauseimpl_trait_with_diagnosticsdeclares no cycle result.Noneis the natural recovery value here: the query already returnsOption, and no resolvable trait ref is exactly what a self-referential impl has.🤖 AI-assisted: understanding the issue, locating the cause, and writing the test.