Repository navigation
ci: Resolve most zizmor findings as of zizmor@1.32.0 - #3261
hashcatHitman wants to merge 11 commits into
Conversation
| with: | ||
| persist-credentials: true # The `publish-guide.sh` script requires this for `git push` |
There was a problem hiding this comment.
I want to get rid of this eventually. I'm pretty sure we wouldn't need it if we migrated to using actions/deploy-pages, which I do think should be done, but I don't currently have the time to figure that out.
| with: | ||
| persist-credentials: true # The `update-dependencies.sh` script requires this for `git push` |
There was a problem hiding this comment.
I don't like this either, but as long as this repo needs that script, it is necessary. We (t-crabwatch/t-infra) should probably try to figure out what behavior is desired and if we can help configure Renovate to provide that behavior.
There was a problem hiding this comment.
this script doesn't work anymore
https://github.com/rust-lang/mdBook/actions/workflows/update-dependencies.yml

renovate is configured https://github.com/rust-lang/mdBook/blob/main/.github/renovate.json5
So maybe we can remove that script in a separate PR?
There was a problem hiding this comment.
The script says Renovate wasn't working correctly:
# Updates all compatible Cargo dependencies.
#
# I wasn't able to get Renovate to update compatible dependencies in a way
# that I like, so this script takes care of it. This uses `cargo upgrade` to
# ensure that `Cargo.toml` also gets updated. This also makes sure that all
# transitive dependencies are updated.So I'm not sure if we can or not...
It looks like it fails because it expects a branch named update-dependencies to exist, which doesn't? I'd ask the author about it.
There was a problem hiding this comment.
It looks like the branch was deleted in #3208, possibly on accident?
cc @GuillaumeGomez (PR author)
cc @ehuss (script author)
There was a problem hiding this comment.
Should have been merged indeed. Although, what's wrong with the branch removal?
There was a problem hiding this comment.
Well, the script we're talking about expects such a branch to exist. But as far as I can tell, there isn't anything that creates that branch? So I suspect it was supposed to be created once and left to exist (it seems like previous PRs did not delete the branch).
There was a problem hiding this comment.
Namely see: https://github.com/rust-lang/mdBook/actions/runs/41257116538/job/124702530066
It tries to fetch the update-dependencies branch and immediately fails because it doesn't exist. It used to work, though.
There was a problem hiding this comment.
Seems like a bug in the script.
There was a problem hiding this comment.
Well, fair enough. I just wasn't sure if you deleted the branch on accident or not. I guess we just have to see if the author wants to fix it or if it's even still needed. Though I don't think any of this really needs to block this PR.
|
CI failure is from |
|
r? crabwatch |
1b16b62 to
ce37826
Compare
This comment has been minimized.
This comment has been minimized.
| with: | ||
| persist-credentials: true # The `update-dependencies.sh` script requires this for `git push` |
There was a problem hiding this comment.
this script doesn't work anymore
https://github.com/rust-lang/mdBook/actions/workflows/update-dependencies.yml

renovate is configured https://github.com/rust-lang/mdBook/blob/main/.github/renovate.json5
So maybe we can remove that script in a separate PR?
ce37826 to
f7b29cc
Compare
This comment has been minimized.
This comment has been minimized.
See: https://github.com/actions/checkout/releases/tag/v7.0.1 This is the same version we're already implicitly using. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/actions/setup-node/releases/tag/v7.1.0 This is the same version we were already implicitly using. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/crate-ci/typos/releases/tag/v1.52.2 This is the same version we're already using. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
It exists, but not where `zizmor` expects. Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
f7b29cc to
88262e0
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
In pursuit of getting more
zizmorlints enforced acrossrust-langrepos throughcrabwatch, this PR fixes mostzizmorfindings as ofzizmor@1.32.0, using theauditorpersona. The lints that actually fired per-persona level are:regularpersona findings:artipacked(seeauditor, though)excessive-permissions(See also: Solve theexcessive-permissionslint crabwatch#97)template-injectionunpinned-usespedanticpersona findings:regularexcessive-permissions(See also: Solve theexcessive-permissionslint crabwatch#97)template-injectionundocumented-permissionsanonymous-definition(Because coming up with names is hard and there is minimal benefit to this)concurrency-limits(Due to concerns about special cases. See also: Determine special cases forconcurrency-limitscrabwatch#107)auditorpersona findings:pedanticartipacked(auditoralso flags explicitly persisted credentials, which were required to keep these workflows functional. they might be removable in the future, but for now, this is just how it is.)