Combine libs team agendas - #845
Conversation
| }) | ||
| }); | ||
| let issues = issues.filter(|i| !self.to_skip.iter().any(|s| *s == i.html_url)); | ||
| let issues = issues.filter(|i| !self.to_skip.contains(&i.html_url)); |
There was a problem hiding this comment.
This came from a clippy fix, kept it.
| serde_json::from_str(&response) | ||
| .wrap_err("response body cannot be deserialized") | ||
| .with_section(|| response.header("Response:"))?) | ||
| .with_section(|| response.header("Response:")) |
There was a problem hiding this comment.
Another clippy fix.
| ###### tags: `Libs Meetings` `Minutes` | ||
|
|
||
| **Meeting Link**: https://meet.jit.si/rust-libs-meeting-ujepnbwg2lzqgt6wvrndwimi | ||
| **Meeting Link**: https://meet.jit.si/rust-libs-meeting-crxoz2at8hiccp7b3ixf89qgxfymlbwr |
There was a problem hiding this comment.
Made sure to use the libs-api meeting link, since that's what's in the calendar PR
|
cc @nia-e |
|
it might make sense to keep separate libs-nominated and libs-api-nominated labels (just for sorting the agenda, since the former tends to produce fewer things); not opposed to changing the name (libs-impl-nominated, to mimic the old team name?). it's a matter for later. either way, lgtm - the stakes on this are not precisely sky-high so if there's no issues that crop up i'll merge this tmrw. |
|
I mean, extremely fair, although I feel like maybe we nominate too many things that should really be ACPs anyway, |
|
one good night's rest later, still lgtm. ty clar <3 |
(sloppily)
for RFC 3984