Add hash_map::{OccupiedEntry::into_entry, VacantEntryRef::insert_entry_with_key}, make EntryRef use ToOwned again - #670
Merged
Conversation
clarfonthey
force-pushed
the
entry-into-entry
branch
2 times, most recently
from
December 3, 2025 14:51
ba2b7a9 to
6a6e760
Compare
Amanieu
added this pull request to the merge queue
Dec 12, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2025
clarfonthey
force-pushed
the
entry-into-entry
branch
2 times, most recently
from
December 13, 2025 03:36
77e0ba8 to
245958a
Compare
Amanieu
enabled auto-merge
December 17, 2025 23:29
auto-merge was automatically disabled
December 18, 2025 02:32
Head branch was pushed to by a user without write access
clarfonthey
force-pushed
the
entry-into-entry
branch
from
December 18, 2025 02:32
245958a to
1e7d7c4
Compare
clarfonthey
changed the title
hash_map::{OccupiedEntry::into_entry, VacantEntryRef::insert_entry_with_key}hash_map::{OccupiedEntry::into_entry, VacantEntryRef::insert_entry_with_key}, make EntryRef use ToOwned again
clarfonthey
force-pushed
the
entry-into-entry
branch
2 times, most recently
from
December 18, 2025 02:48
ee2b227 to
a60425d
Compare
* Add hash_map::{OccupiedEntry::into_entry, VacantEntryRef::insert_entry_with_key}
* Make hash_map::EntryRef use ToOwned instead of From/Into
clarfonthey
force-pushed
the
entry-into-entry
branch
from
December 18, 2025 02:51
a60425d to
3338af3
Compare
Contributor
Author
|
Things should now compile, and remaining references in docs to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows implementing
get_or_insertandget_or_insert_withwithout accessing the internals ofHashMap, which is useful for #666.Since the merge queue is busted, I decided to incorporate the suggestion to make
EntryRefuseToOwnedagain.Resolves #660.