Allow override inherited default-features - #387
Merged
Conversation
Signed-off-by: 0xPoe <poe.liu@pm.me>
rustbot
added
the
S-waiting-on-review
traviscross
approved these changes
Aug 11, 2026
traviscross
removed
the
S-waiting-on-review
Contributor
|
Thanks @0xPoe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After rust-lang/cargo#17126, we now allow overriding inherited default features. We need to update the document to mention this change.
I’m not sure whether users who migrate from the 2021 edition or earlier to the 2024 edition, especially 1.99+, will be surprised or confused by this behavior change. But as the standard workflow is to run
cargo fix --editionfirst, users should notice this change and then decide which behavior they really want. So I hope this change won’t create more chaos here. We just need to clarify the behavior in the corresponding version correctly.cc: @epage