controllers/owners: Resolve removal owner names in Rust - #14681
Merged
Merged
Conversation
Turbo87
added
the
C-internal 🔧
moskirathe
approved these changes
Sep 15, 2026
eth3lbert
approved these changes
Sep 15, 2026
`Crate::remove_owners()` soft-deletes selected user and team identities with one Diesel update scoped to the crate. Matching includes the owner kind so users and teams with the same ID remain distinct. Co-authored-by: moskirathe <tech@alphajiri.co>
Owner removals now resolve all supplied names against the initial owner list before updating ownership rows in one query. Repeated names select the same owners, and missing names fail before any updates. The transaction still rejects removing every individual owner. The name-based SQL removal method is no longer needed. Co-authored-by: moskirathe <tech@alphajiri.co>
Turbo87
force-pushed
the
owner-removal-resolver
branch
from
September 16, 2026 11:21
15801b3 to
35c4ad0
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removal handler now resolves owner names against the initial owner list in Rust before passing user and team identities to a single database update. This separates name resolution from row removal, simplifies the SQL query and prepares the handler to support distinct
crates.io:andgithub:namespaces in the next PR.Related
cargo ownerparam handling and error messages #13769