Mark static_flag and shared_flag as deprecated#1582
Conversation
NobodyXu
left a comment
There was a problem hiding this comment.
We can have these functions deprecated, but we cannot just remove them as it would break compatibility and release a 2.0.0 release
|
emmm, can we create a version 2.0 branch then? i can change the PR target. |
|
We have absolutely no plan for 2.0, that'll just render too many build script to stick to a 1.0 version so we'd either backport to maintain 1.0 or give them up, which is not realistic |
|
huh, and people really are using them even if they do nothing. how about i also add a |
Thanks this reminds me, some does use it to build shared lib I think?
Hmmm no that's bad, I'd prefer deprecated if we really want to do that |
it won't work though. all they would get is |
static_flag and shared_flag as deprecated
NobodyXu
left a comment
There was a problem hiding this comment.
Thank you!
can you fix the semver-checks CI?
I think we would need to add
with:
release-type: minor
to
cc-rs/.github/workflows/main.yml
Line 436 in 1ca8b2a
|
This PR just need a rebase |
They are meaningless since cc-rs only generates static libraries. Closes rust-lang#1444 Closes rust-lang#594
|
Thanks |
They are meaningless since cc-rs only generates static libraries. Having them does nothing and only causes confusion.
Closes #1444
Closes #594