Skip to content

Mark static_flag and shared_flag as deprecated#1582

Merged
NobodyXu merged 1 commit into
rust-lang:mainfrom
yshui-forks:main
Oct 24, 2025
Merged

Mark static_flag and shared_flag as deprecated#1582
NobodyXu merged 1 commit into
rust-lang:mainfrom
yshui-forks:main

Conversation

@yshui

@yshui yshui commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

They are meaningless since cc-rs only generates static libraries. Having them does nothing and only causes confusion.

Closes #1444
Closes #594

@NobodyXu NobodyXu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have these functions deprecated, but we cannot just remove them as it would break compatibility and release a 2.0.0 release

@yshui

yshui commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

emmm, can we create a version 2.0 branch then? i can change the PR target.

@NobodyXu

NobodyXu commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

We have absolutely no plan for 2.0, that'll just render too many build script to stick to a 1.0 version so we'd either backport to maintain 1.0 or give them up, which is not realistic

@yshui

yshui commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

huh, and people really are using them even if they do nothing.

how about i also add a doc(hidden)?

@NobodyXu

NobodyXu commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

huh, and people really are using them even if they do nothing.

Thanks this reminds me, some does use it to build shared lib I think?

how about i also add a doc(hidden)?

Hmmm no that's bad, I'd prefer deprecated if we really want to do that

@yshui

yshui commented Oct 5, 2025

Copy link
Copy Markdown
Contributor Author

use it to build shared lib I think?

it won't work though. all they would get is liblibfoo.so.a.

@yshui yshui changed the title Remove shared_flag and static_flag Mark static_flag and shared_flag as deprecated Oct 5, 2025
@yshui yshui requested a review from NobodyXu October 5, 2025 06:08

@NobodyXu NobodyXu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

can you fix the semver-checks CI?

I think we would need to add

with:
  release-type: minor

to

- name: Check semver

NobodyXu added a commit that referenced this pull request Oct 24, 2025
NobodyXu added a commit that referenced this pull request Oct 24, 2025
@NobodyXu

Copy link
Copy Markdown
Contributor

This PR just need a rebase

They are meaningless since cc-rs only generates static libraries.

Closes rust-lang#1444
Closes rust-lang#594
@NobodyXu NobodyXu merged commit a0b2fd6 into rust-lang:main Oct 24, 2025
79 checks passed
@NobodyXu

Copy link
Copy Markdown
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shared_flag and static_flag don't work

2 participants