Skip to content

Bump msrv to 1.85#1513

Open
NobodyXu wants to merge 6 commits into
mainfrom
bump-msrv
Open

Bump msrv to 1.85#1513
NobodyXu wants to merge 6 commits into
mainfrom
bump-msrv

Conversation

@NobodyXu

Copy link
Copy Markdown
Contributor

Debian 13 has released with rustc 1.85

@djc

djc commented Aug 10, 2025

Copy link
Copy Markdown

I hope this won't be merged/released for a few more months.

@NobodyXu

Copy link
Copy Markdown
Contributor Author

I agree that we should at least wait for weeks, at least until many has migrated to debian 13

@cuviper

cuviper commented Aug 10, 2025

Copy link
Copy Markdown
Member

Is Debian the only consideration?

RHEL 8/9/10 only have 1.84 right now, but they'll be upgraded in the next minor release, around November.

@NobodyXu

Copy link
Copy Markdown
Contributor Author

RHEL 8/9/10 only have 1.84 right now, but they'll be upgraded in the next minor release, around November.

Thanks, it sounds good to wait until then

@NobodyXu

NobodyXu commented Aug 21, 2025

Copy link
Copy Markdown
Contributor Author

Todo

  • change max_by to max_by_key
  • use std::sync::OnceLock

@NobodyXu

Copy link
Copy Markdown
Contributor Author

looks like msrv 1.70 is more reasonable, it contains many stdlib API we want

@dot-asm

dot-asm commented Sep 21, 2025

Copy link
Copy Markdown
Contributor

Debian 13 has released with rustc 1.85

The logic is flawed. The fact that a specific vendor released a thing doesn't mean that a) everybody is running the same distro, b) everybody immediately upgrades. If anything, the community is better served if the decision is governed by when releases go out of support, not by when they are released.

@NobodyXu

Copy link
Copy Markdown
Contributor Author

I'm not planning to merge this PR right now, it's going to be months before it's merged

@ChrisDenton

Copy link
Copy Markdown
Member

The relevant zulip discussion.

@dot-asm

dot-asm commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

The relevant zulip discussion.

Relevant question is if those minority users are simply being obtuse or have no choice. I for one have no choice when I target ARM Morello. They have updated to 1.72 in September. From 1.56. But of course you don't have to care :-) But I do pledge implore you to not assume that everybody runs Debian and is about to upgrade.

@NobodyXu

Copy link
Copy Markdown
Contributor Author

Yes we would probably bump msrv to 1.70 instead, in 6-12 months or even longer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants