Open
Conversation
JackDanger
force-pushed
the
jackdanger/pass-through-puma-config
branch
from
df148bf to
e68b750
Compare
JackDanger
added a commit
to Gusto/gemstash-public-fork-archive
that referenced
this pull request
Dec 6, 2018
Sent upstream at: rubygems#205
This changes threads the `gemstash_env.config` options for Puma through to the `Puma::CLI.new` call. Prior to this change `:puma_workers` and `:puma_threads` were ignored when booting Gemstash via the CLI
JackDanger
force-pushed
the
jackdanger/pass-through-puma-config
branch
from
e68b750 to
a031473
Compare
olleolleolle
reviewed
Dec 6, 2018
Member
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
It seems one of the new methods was not called.
lib/gemstash/cli/start.rb
Outdated
|
|
||
| def store_pidfile | ||
| gemstash_env.pidfile = pidfile? | ||
| end |
Member
There was a problem hiding this comment.
This method and #pidfile? are unused. Perhaps it's not meant to be a part of this changeset?
Contributor
|
@olleolleolle Let me know if further updates are required. |
This effectively applies commit 7624401 When gusto/redis is merged in upstream, then this commit becomes unnecssary. For now gusto's gemstash fork is in an unideal inbetween state
Member
|
Would like to test this before merge 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes threads the
gemstash_env.configoptions for Puma through to thePuma::CLI.newcall.Prior to this change
:puma_workersand:puma_threadswere ignored when booting Gemstash via the CLI