Repository navigation
Keep the original Netty package intact when shading - #172
Merged
Merged
Conversation
Prepend com.rabbitmq.marchhare.shaded to io.netty instead of replacing io.netty with a namespace ending in netty. Netty's native library loader requires each relocated class name to end with its complete original class name when calculating the shading prefix. Rebuild the bundled JAR and add a regression test that reproduces the native loader failure with the previous relocation.
Member
|
Thank you, @jsvd! |
Contributor
|
👋 @michaelklishin do you have an estimate for next release? 🙏 |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netty's native library loader rejects the relocation introduced in #171 because it replaces the original
io.nettypackage. Its prefix calculation requires the relocated class name to end with the complete original class name, otherwise it throwsUnsatisfiedLinkError.Change the relocation target to
com.rabbitmq.marchhare.shaded.io.netty, rebuild the bundled JAR, and clarify the package requirement in the build comments and contributor instructions. Add a regression test that exercises Netty's prefix calculation without requiring a platform-specific native library.Validation:
git diff --checkpass