Skip to content

Ignored x-queue-type in arguments #165

Closed

Description

@evgeny-test

Hi!

I'm using a logstash 9.1.3 and plugin logstash-integration-rabbitmq.
Any x-queue-type is ignored and a classic queue is always created.

I've looked at the code and found a recent edit that I think has a logical error.
In the queue.rb file, line 65: @type will never be empty because it is always set on line 57.
For myself, as a patch, I made an edit on line 57: type => "".

I can't understand your code well, so I can't offer an MR.

Thanks for your work!

Activity

  1. michaelklishin commented on Sep 11, 2025

    @michaelklishin
    Member

    I can reproduce this with MarchHare::Queue#queue but not MarchHare::Queue#quorum_queue. But yeah, Logstash uses the former for many reasons, including historical.

    I'm looking into it, thanks for doing the initial investigative work. I appreciate it.

  2. added a commit that references this issue on Sep 11, 2025
    9dd1360
  3. added this to the 4.8.0 milestone on Sep 11, 2025
  4. michaelklishin commented on Sep 11, 2025

    @michaelklishin
    Member

    @evgeny-test a fix #166 is out in 4.8.0.

    Because there will be existing queues with an incorrect queue type, I should mention this relatively unknown queue property equivalence check setting to you (and you should mention to the Logstash maintainers).

    I'd recommend mentioning the setting in the Logstash release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions