Skip to content

Drop the Gradient.Stop decode workaround once skip-fuse-ui exposes a public init #20

Description

@rozd

Skip's Gradient.Stop initializer is internal, so Sources/ThemeKit/Gradient+Codable.swift decodes gradients on Android by constructing stops and mutating them into place.

A one-line upstream fix (making the init public) was written and verified on a local skip-fuse-ui fork — positive build, negative control (error: 'Gradient.Stop' initializer is inaccessible due to 'internal' protection level), and a device log confirming a 3-stop gradient decodes with the right locations.

Trigger: a skip-fuse-ui release containing the public init.

Then:

  • delete the stop-mutation workaround in Sources/ThemeKit/Gradient+Codable.swift
  • raise the skip-fuse-ui floor in Package.swift to that release
  • update the "Version requirements" table in README.md to match

Blocked on the upstream PR being submitted and merged (see the upstream-submission issue).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions