[FIX] Implement error handling for SendGrid responses and validate email content#3
Merged
Merged
Conversation
…ail content - Added `sendGridResponseError` function to handle non-retryable errors for SendGrid 4xx responses. - Updated `ToSendGrid` and `ToSMTP` methods to return `ErrEmptyContent` if email content is empty. - Introduced tests for empty email content and SendGrid error handling. - Enhanced error propagation in the `RenderString` function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of changes
Implement error handling for SendGrid responses and validate email content
sendGridResponseErrorfunction to handle non-retryable errors for SendGrid 4xx responses.ToSendGridandToSMTPmethods to returnErrEmptyContentif email content is empty.RenderStringfunction.Type of change
Acceptance criteria
This change will be merged with no review required.
Author checklist