fix(authbridge): rename plugins_sparc.go to avoid Go GOARCH filename collision - #736
Open
vz-ibm wants to merge 1 commit into
Open
fix(authbridge): rename plugins_sparc.go to avoid Go GOARCH filename collision#736vz-ibm wants to merge 1 commit into
vz-ibm wants to merge 1 commit into
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Go's build system treats any *_GOARCH.go filename as an implicit architecture constraint, and "sparc" is itself a legacy GOARCH value (for the SPARC CPU). This silently excluded the sparc plugin's wiring file from every normal amd64/arm64 build of authbridge-proxy, regardless of its explicit //go:build !exclude_plugin_sparc line -- affecting every published authbridge image tag, not just a stale cache. Verified by rebuilding after the rename: the sparc plugin's own string literals now appear in the compiled binary, and deploy-agent.sh --plugin-preset sparc-only resolves the sparc plugin successfully. Content unchanged, filename only. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Vitaly Zabershinsky <VITALYZ@il.ibm.com>
vz-ibm
force-pushed
the
fix/sparc-plugin-goarch-collision
branch
from
August 4, 2026 14:04
876b3b6 to
21484c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
sparcplugin is never compiled into anyauthbridge-proxybuild, onevery published image tag we tried (
v0.6.0-alpha.12,v0.7.0-alpha.2) andeven a fresh from-source build of
mainwith default (empty)GO_BUILD_TAGS.The sidecar's registered-plugin list is always missing
sparc:Root cause
authbridge/cmd/authbridge-proxy/plugins_sparc.gohas an explicit//go:build !exclude_plugin_sparcconstraint, which correctly evaluatestrueby default (same pattern as every otherplugins_*.gofile in thatdirectory). But Go's build tool also applies an implicit constraint based
on filename: any file matching
*_GOARCH.gois restricted to thatarchitecture — and
sparcis itself a legacy GoGOARCHvalue (for thehistorical SPARC CPU, alongside
sparc64; seego/build/syslist.go'sknownArch). Soplugins_sparc.gois silently interpreted as "only buildwhen
GOARCH=sparc" and excluded from every normalamd64/arm64build —independent of, and regardless of, the explicit
//go:buildline.This is a permanent bug affecting every build of the "full"
authbridgeimage (the
authbridge-litevariant already excludessparcon purpose viaits own
GO_BUILD_TAGS, so it's unaffected/expected).Verification
Built a throwaway copy of
authbridge/with only this rename applied(content otherwise unchanged) and confirmed the plugin's own string literal
(
"sparc: reflector unavailable, failing open") now appears in the compiledbinary via
strings. Rebuilt the real local image with the same rename andconfirmed
deploy-agent.sh --plugin-preset sparc-only(rossoctl/workload-harness)now resolves the plugin correctly end-to-end:
and the AuthBridge sidecar logs
reloader: pipelines swapped/drained old pipelinesconfirming the SPARC-enabled config loaded live.Fix
Pure rename, no logic change:
plugins_sparc.go→plugins_sparcplugin.go.Note
sparcis present on bothmainandrelease-0.6— this fix likely needsbackporting to
release-0.6as well if that branch still cuts patchreleases.