Skip to content

[DO NOT MERGE][ABI test] rolling / additions only: expect "ABI compatible" + 4 backport labels - #3380

Closed
fujitatomoya wants to merge 1 commit into
rollingfrom
abi-test/rolling-additions-only
Closed

fujitatomoya wants to merge 1 commit into
rollingfrom
abi-test/rolling-additions-only

Conversation

@fujitatomoya

Copy link
Copy Markdown
Collaborator

Case: target rolling, new exported non-virtual member function rclcpp::Duration::is_zero() (one added symbol in librclcpp.so, no layout or vtable change).


This is a test pull request for the ABI checker (abi.yaml / abi-report.yaml, backed by
fujitatomoya/ros2-abi-action) and the
backport-<distro> candidate labels (#2555). It exists only for fujitatomoya to verify the
action result for one specific case, and it is closed without merging once that is done.
Maintainers: nothing to review here, please ignore this pull request.

🤖 Generated with Claude Code

ABI checker / backport label test; this pull request is closed without merging.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@fujitatomoya

fujitatomoya commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator Author

Expected result

  • abi check: success; librclcpp.so additions-only, the other three compatible
  • sticky comment: Verdict: compatible (additions only)
  • label ABI compatible added, ABI break absent
  • backport labels added (additions-only counts as compatible in abi-report.yaml): backport-lyrical, backport-kilted, backport-jazzy, backport-humble

@github-actions

Copy link
Copy Markdown

ABI Compliance Check

✅ Verdict: compatible (additions only)

Library Verdict Summary
libcomponent_manager.so ✅ compatible No ABI changes detected.
librclcpp.so ✅ additions-only ABI changed but only with additions (backward-compatible).
librclcpp_action.so ✅ compatible No ABI changes detected.
librclcpp_lifecycle.so ✅ compatible No ABI changes detected.
✅ libcomponent_manager.so — full abidiff report

Compared:

  • Base: lib-base/libcomponent_manager.so
  • Head: lib-pr/libcomponent_manager.so @ f7cfc0b
(empty report — no differences printed by abidiff)
✅ librclcpp.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp.so
  • Head: lib-pr/librclcpp.so @ f7cfc0b
Functions changes summary: 0 Removed, 0 Changed, 1 Added function
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

1 Added function:

  [A] 'method bool rclcpp::Duration::is_zero() const'    {_ZNK6rclcpp8Duration7is_zeroEv}


✅ librclcpp_action.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_action.so
  • Head: lib-pr/librclcpp_action.so @ f7cfc0b
(empty report — no differences printed by abidiff)
✅ librclcpp_lifecycle.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_lifecycle.so
  • Head: lib-pr/librclcpp_lifecycle.so @ f7cfc0b
(empty report — no differences printed by abidiff)

Updated for commit f7cfc0b · check run · suppressions: /home/runner/work/_temp/ros2-abi-suppressions.txt

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed expected result, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant