Skip to content

feat(i18n): add Simplified Chinese localization - #444

Open
everfu wants to merge 2 commits into
ronitsingh10:mainfrom
everfu:feat/zh-hans-localization
Open

everfu wants to merge 2 commits into
ronitsingh10:mainfrom
everfu:feat/zh-hans-localization

Conversation

@everfu

@everfu everfu commented Sep 11, 2026

Copy link
Copy Markdown

Adds Simplified Chinese (zh-Hans) using native Xcode string catalogs and Swift localization APIs. Settings, device and EQ controls, notifications, accessibility labels, and permission prompts resolve in the system-selected language. English remains the source language; persisted enum values and user-provided names retain their existing identifiers and content.

Includes plural forms and regression tests for English/Chinese lookups, translation coverage, interpolation placeholders, permission strings, and stable persisted values.

Validation: Debug build and the localization/device-inspector formatter tests passed as part of a 65-test targeted run. Chinese UI layout has not been manually verified across all screens.

Related localization proposals: #420 and #386.

@shiyuenianwu

shiyuenianwu commented Oct 21, 2026 •

Copy link
Copy Markdown

Real-device test notes, in case they help get this merged.

Correction to my first version: I initially listed the three device-change notification titles/bodies and the Auto: captions as untranslated. That was wrong — they are translated in this branch. My comparison had been against main's older wording (app(s) vs apps), so the keys didn't line up.

I built this branch with xcodebuild -project FineTune.xcodeproj -scheme FineTune -configuration Release CODE_SIGNING_ALLOWED=NO on the GitHub macOS 26 runner, ad-hoc re-signed it, and installed it on macOS 27.0.1 (Apple silicon). Build was clean, no crash, and no layout breakage in the menu bar popup, the settings tabs or the EQ panel. The compiled bundle carries 277 zh-Hans entries.

Labels I still see falling back to English, checked against this branch's catalog rather than main:

  • Volume: in EditablePercentage
  • Selected / Unselected in DeviceBadge
  • Primary / Secondary / Tertiary in the design-system modifiers
  • Zoom, External Display, Active Applications
  • interpolated captions: Mode: %@, Following default: %@, Current: %@, Selected: %@, Selected: %lld devices
  • EQ Panel Content, Expanded Content, Expanded detail content here

I added 19 zh-Hans entries for those on top of this branch: catalog 287 → 305 entries, zh-Hans coverage 279 → 294. It builds clean with the same workflow. Cherry-pick if useful:

shiyuenianwu@6e46a86

(The branch also carries a throwaway .github/workflows/build-unsigned.yml I used to produce the build on a machine without Xcode. Ignore that commit.)

Thanks for putting this together — the string catalog plus InfoPlist approach is clearly the right shape for this project.

shiyuenianwu added a commit to shiyuenianwu/FineTune that referenced this pull request Oct 21, 2026
…h10#444

Adds 19 zh-Hans entries that still fell back to English:
- Volume:, Selected, Unselected, Primary, Secondary, Tertiary
- Zoom, External Display, Active Applications
- Mode: %@, Following default: %@, Current: %@, Selected: %@, Selected: %lld devices
- EQ Panel Content, Expanded Content, Expanded detail content here
- Dark frosted glass background, EQ Card - Lifted

Catalog goes from 287 to 305 entries, zh-Hans coverage 279 to 294 (96%).
Sionea added a commit to Sionea/FineTune-zh-Hans that referenced this pull request Oct 25, 2026
在社区简化中文 PR(ronitsingh10#444, by @everfu)基础上做的个人修改,不用于官方发布。

主要改动:
- 移除 Sparkle 自动更新:删除 UpdateManager、设置里的「更新」标签页、
  appcast.xml、Info.plist 里的 SUFeedURL / SUPublicEDKey /
  SUEnableInstallerLauncherService,并从 SPM 依赖和 Package.resolved 中摘掉 Sparkle
- 清理 Localizable.xcstrings 中仅更新页使用的文案键
- 版本号改为 2.0.0,构建号 20261025
- About 页标注「个人修改版 · 已移除自动更新」,保留原作者署名与 GPL-3.0
- 删除依赖上游签名密钥的 release.yml(appcast 发布流程随自动更新一并移除)

上游:https://github.com/ronitsingh10/FineTune (GPL-3.0)
Apply 17 reviewed translations from shiyuenianwu/6e46a862 without catalog reformatting or the temporary build workflow. Preserve Zoom as an app brand and the explicitly nontranslatable preview placeholder. These labels are used in previews, not shipping interface controls. Keep existing notifications and localization entries unchanged.

Validate compiled caption interpolation, all 292 translatable catalog entries, permission resources, and the Debug app build with six localization tests.

Co-authored-by: shiyuenianwu <shiyuenianwu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants