Skip to content

Revert "fix(tests): five rfdetr-seg static-crop tests shadow each other by name" #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PawelPeczek-Roboflow merged 1 commit into from
Sep 11, 2026
+5 −5
Merged

Revert "fix(tests): five rfdetr-seg static-crop tests shadow each other by name" #2971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions inference_models/tests/integration_tests/models/test_rfdetr_seg_predictions_onnx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1085,7 +1085,7 @@ def test_package_with_static_crop_letterbox_against_torch_batch_input(

@pytest.mark.slow
@pytest.mark.onnx_extras
def test_package_with_static_crop_center_crop_against_numpy_input(
def test_package_with_static_crop_letterbox_against_numpy_input(

@github-actions github-actions Bot Sep 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium — this revert reintroduces the name shadowing that #2948 fixed.

After this revert, five test names each appear twice in this module:

  • test_package_with_static_crop_letterbox_against_numpy_input — line 938 (uses ..._static_crop_letterbox_package) and line 1088 (uses ..._static_crop_center_crop_package)
  • test_package_with_static_crop_letterbox_against_numpy_list_input — lines 965 / 1121
  • test_package_with_static_crop_letterbox_against_torch_input — lines 996 / 1164
  • test_package_with_static_crop_letterbox_against_torch_list_input — lines 1023 / 1197
  • test_package_with_static_crop_letterbox_against_torch_batch_input — lines 1054 / 1240

Because these are module-level defs with identical names, Python keeps only the last definition. pytest collects only the second occurrence of each (the center_crop-fixture versions at 1088–1240); the five genuine letterbox static-crop tests at 938–1084 are silently dropped from collection — never run, no failure, no skip. That is the exact regression #2948 was renaming these functions to fix.

I understand this is a deliberate revert for CLA reasons (per your "Reverting due to no CLA" comment) rather than a technical disagreement with the fix. Flagging only so the coverage loss is on record: the letterbox static-crop ONNX path loses its five tests until the rename is re-applied under proper attribution.

Reviewed at HEAD: 624a10f

snake_image_numpy: np.ndarray,
snakes_rfdetr_seg_onnx_static_bs_static_crop_center_crop_package: str,
) -> None:
Expand Down Expand Up @@ -1118,7 +1118,7 @@ def test_package_with_static_crop_center_crop_against_numpy_input(

@pytest.mark.slow
@pytest.mark.onnx_extras
def test_package_with_static_crop_center_crop_against_numpy_list_input(
def test_package_with_static_crop_letterbox_against_numpy_list_input(
snake_image_numpy: np.ndarray,
snakes_rfdetr_seg_onnx_static_bs_static_crop_center_crop_package: str,
) -> None:
Expand Down Expand Up @@ -1161,7 +1161,7 @@ def test_package_with_static_crop_center_crop_against_numpy_list_input(

@pytest.mark.slow
@pytest.mark.onnx_extras
def test_package_with_static_crop_center_crop_against_torch_input(
def test_package_with_static_crop_letterbox_against_torch_input(
snake_image_torch: torch.Tensor,
snakes_rfdetr_seg_onnx_static_bs_static_crop_center_crop_package: str,
) -> None:
Expand Down Expand Up @@ -1194,7 +1194,7 @@ def test_package_with_static_crop_center_crop_against_torch_input(

@pytest.mark.slow
@pytest.mark.onnx_extras
def test_package_with_static_crop_center_crop_against_torch_list_input(
def test_package_with_static_crop_letterbox_against_torch_list_input(
snake_image_torch: torch.Tensor,
snakes_rfdetr_seg_onnx_static_bs_static_crop_center_crop_package: str,
) -> None:
Expand Down Expand Up @@ -1237,7 +1237,7 @@ def test_package_with_static_crop_center_crop_against_torch_list_input(

@pytest.mark.slow
@pytest.mark.onnx_extras
def test_package_with_static_crop_center_crop_against_torch_batch_input(
def test_package_with_static_crop_letterbox_against_torch_batch_input(
snake_image_torch: torch.Tensor,
snakes_rfdetr_seg_onnx_static_bs_static_crop_center_crop_package: str,
) -> None:
Expand Down
Loading