Bound WebRTC video uploads and clean up owned files - #2960
Conversation
|
👋 Thanks for the pull request! Here is how automated Claude review works here, so you spend credits (and reviewer time) wisely. 🚧 Right now this is a draft, so automated Claude review is paused — nothing is being spent yet. Mark it Ready for review to trigger it. Warning 💸 The Claude reviewer bills in credits, not vibesAutomated review spins up a real agent that reads real code and spends real credits on every pass. It is glad to help — but it is not a rubber duck, a linter you poke in a loop, or a substitute for reading the contributing guide. Treat it like an expensive senior reviewer whose time you booked, and show up prepared. Draft when unsure, Ready when you mean it:
However you get there, arrive prepared:
Reviews are not free. A draft costs nothing to review; a Ready PR is a promise that it is worth reviewing.
|
PawelPeczek-Roboflow
left a comment
There was a problem hiding this comment.
I believe we have potential mismatch between client and server priors, which if adjusted though publicly exposed knobs would cause errors.
Client sdk could set WEBRTC_VIDEO_UPLOAD_CHUNK_SIZE not matching server-side CHUNK_SIZE. When this is done, server makes wrong assumptions regrading expected number of chunks.
As a result:
- Server log: "Video upload rejected" with a traceback ending in "Invalid video upload chunk count". Misleading. The count is correct for the chunk size the client chose.
- Client: "Upload channel closed during upload". No size, no reason.
|
Thanks Pawel, still in draft, I need to do more testing and try to simplify this. |
Description
WebRTC file uploads can retain arbitrary data and orphan temporary files; apply the existing video input budget to one validated upload per session and clean up failed or closed uploads.
Type of change
How has this change been tested?
Any specific deployment considerations
MAX_VIDEO_DOWNLOAD_SIZE_MB(512 MiB default; negative values opt out) and the existing 48 KiB WebRTC chunk size. The default permits at most 10,923 chunks; custom chunk sizes must fit this envelope.