Fix scheduled skill lifecycle duplication - #48
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Ritesh Verma <riteshverma@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Scheduled jobs that resolved a skill were running skill lifecycle hooks twice after
/runsgained lifecycle handling: once inSchedulerService._schedule_job()and again insideprocess_run(). A scheduledmarket_analystjob could get its prompt wrapped twice,web_clippercould fetch/archive twice, and failed scheduled runs could still emit scheduler success notifications.Celery enqueue failures could also leave a durable run stuck in
accepted/startingafter the row was written but before a task was queued.Root cause
The scheduler kept its pre-existing skill resolve/success/failure hook calls while delegating execution to
process_run(), which now owns the same lifecycle. The Celery execution boundary propagated.delay()failures without updating run status.Fix
skill_idtoprocess_run()and stop invoking skill lifecycle hooks in the scheduler.process_run()results as scheduler failures, so scheduler notifications match terminal run status.Validation
PYTHONPATH=/tmp/s18-test-deps python3 -m pytest tests/test_skills_runs.py tests/test_celery_app.py— 8 passed, 1 Starlette/httpx deprecation warning.