fix: correct MPT issuance ID computation and amm info hint in init templates#41
Open
shichengripple001 wants to merge 1 commit into
Open
fix: correct MPT issuance ID computation and amm info hint in init templates#41shichengripple001 wants to merge 1 commit into
shichengripple001 wants to merge 1 commit into
Conversation
…mplates - Use sequence + accountID (192-bit) instead of LedgerIndex (256-bit) for MPTokenIssuanceID — the binary codec expects Hash192, not Hash256 - Fix amm info hint to use --asset/--asset2 flags and --node instead of the invalid positional + --local syntax Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shichengripple001
force-pushed
the
fix/example-scripts-mpt-amm
branch
from
0907e56 to
339a5a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXAMPLE_MPT_SCRIPTandEXAMPLE_MPT_LOCALwere usingLedgerIndex(256-bit) as theMPTokenIssuanceID, butripple-binary-codecexpectsHash192(192-bit = sequence 4 bytes + accountID 20 bytes). This causedInvalid Hash length 32when trying to sign theMPTokenAuthorizetransaction.xrpl-up amm info XRP USD.<address> --local). Fixed to use--asset/--asset2flags and--node local.Test plan
xrpl-up run scripts/example-mpt.tslocally — MPT issuance, opt-in, transfer, and balance check all succeedxrpl-up amm info --asset XRP --asset2 USD/<address> --node local— returns pool info correctly🤖 Generated with Claude Code