Postgres Economy DB support - #4
Open
lukasbischof wants to merge 6 commits into
Open
Conversation
lukasbischof
force-pushed
the
feature/economy-db-support
branch
from
July 30, 2026 09:25
fac2e86 to
3087d81
Compare
The backup is already compressed, so compressing again makes little sense
lukasbischof
force-pushed
the
feature/economy-db-support
branch
from
July 30, 2026 09:29
3087d81 to
2ff7519
Compare
lukasbischof
commented
Jul 30, 2026
Comment on lines
+68
to
+71
| when DEDICATED_KIND | ||
| PostgresBackupService.new(data: data, name: name, dry_run: @nctl.dry_run) | ||
| when ECONOMY_KIND | ||
| PostgresDatabaseBackupService.new(db_ref: db_ref, data: data, nctl_client: @nctl, name: name) |
Member
Author
There was a problem hiding this comment.
Extracted the logic that previously was inlined here into two services, one for managing dedicated dbs and one for the shared dbs
Comment on lines
+22
to
36
| def list(name) | ||
| backups = backup_service_for(name).backups | ||
| if backups.empty? | ||
| Output.warning("No backups found for '#{name}'") | ||
| return | ||
| end | ||
|
|
||
| fqdn = data.dig("status", "atProvider", "fqdn") | ||
| if fqdn.nil? || fqdn.empty? | ||
| Output.error("Database FQDN not found; cannot capture backup.") | ||
| exit 1 | ||
| rows = backups.map do |backup| | ||
| [format_time(backup["ModTime"]), format_size(backup["Size"]), backup["Name"]] | ||
| end | ||
|
|
||
| cmd = ["ssh", "dbadmin@#{fqdn}", "sudo nine-postgresql-backup"] | ||
| Output.command(cmd.join(" ")) | ||
| system(*cmd) unless @nctl.dry_run | ||
| Output.table(rows, headers: ["DATE", "SIZE", "NAME"]) | ||
| rescue Deploio::Error => e | ||
| Output.error(e.message) | ||
| exit 1 | ||
| end |
Member
Author
There was a problem hiding this comment.
Sneaky new feature: Implemented a list command for economy dbs as it's fairly cheap (we have to list the backups anyway).
Implementing the list for dedicated dbs and actually letting the user chose the backup they want to download is up for a new PR.
Comment on lines
-103
to
-110
| def build_option_args | ||
| args = [] | ||
| args << "--dry-run" if options[:dry_run] | ||
| args << "--no-color" if options[:no_color] | ||
| args << "--app" << options[:app] if options[:app] | ||
| args << "--org" << options[:org] if options[:org] | ||
| args | ||
| end |
Member
Author
There was a problem hiding this comment.
Moved to shared_options
| args << "--app" << merged_options[:app] if merged_options[:app] | ||
| args << "--org" << merged_options[:org] if merged_options[:org] | ||
| args | ||
| end |
Member
Author
There was a problem hiding this comment.
So essentially, you can now have --dry-run everywhere
lukasbischof
marked this pull request as ready for review
July 30, 2026 09:44
coorasse
reviewed
Jul 31, 2026
coorasse
left a comment
coorasse
left a comment
Member
There was a problem hiding this comment.
I like the implementation but why do we need the "forwarded options"? I think you can access "parent_options" already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we moved most of our databases to the economy tier, I now miss the
pg backups downloadcommand. This PR implements it as backups finally got implemented by Nine 🎉 . It works like this:rcloneDownload:
List: