Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Updates
katexinrehype-katexfrom^0.16.0to^0.19.0.katexbelow0.18.2is affected by GHSA-238p-pmpm-9mq7, and the current range keeps dependents from getting the fix without an override.Closes GH-121.
@types/katexis removed:katexships its own typeskatex@0.19.0: KaTeX0.18prefixed a number of internal class names (base→katex-baseand so on), so markup from this version needs the matching stylesheet\begin{split}\end{{split}}, which KaTeX now reports as aParseError(fix(environment): report invalid environment names as ParseError KaTeX/KaTeX#4256), so it no longer reached the fallback branch; it now uses\begin{array}{{c}}…, which still throws a plainErroron both0.16and0.19The
lib/code needs no change: it only usesrenderToString, and the options it passes (throwOnError,strict: 'ignore') behave the same.Because of the class name change I think this is a breaking change for users who load KaTeX’s CSS themselves, so it probably warrants a major. This matches the review on micromark/micromark-extension-math#14, which does the same update for the package
remark-mathuses.Note: locally (Node 24) the “should handle errors, support
errorColor” test fails on aVFileMessageshape difference; it fails the same way onmainwithout this change, so it is unrelated.