Repository navigation
Upgrade to MathJax v4 - #118
jajaperson wants to merge 9 commits into
Conversation
Actually didn't require any susbtantial changes to the code, mostly I needed to update the tests. I also updated testing so that there is a script for updating fixtures, which should obviously only be run for major bumps. Since `AllPackages` is no longer included in MathJax, I had to write our own, which meant enabling side effects for the package. Also, it appears MathJax doesn't really throw errors anymore. The old version of this package tested error handling by attempting to render some weird unicode, but this doesn't even register as an error anymore (although it does produce gobbledeegook output). A TeX syntax error renders the source TeX in red, as shown by the `error.html` fixture. I have left the renderer in a try/catch block but I haven't been able to test this behaviour.
github-actions
Bot
added
👋 phase/new
|
The checks are failing due to |
|
I've run into an error when trying to write |
|
The font issue I spoke about seems limited to SVG, and also seems to be an upststream issue (see mathjax/MathJax#3522). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 15 15
Lines 1823 1974 +151
==========================================
+ Hits 1823 1974 +151 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
And now yargs is playing up due to some upstream change. May I ask why this repo does not use a package lock? |
Suggestions by @dpvc See mathjax/MathJax#3591
|
If anyone else is seeing this, you can install my updated version as |
Initial checklist
Description of changes
Fixes #114
Apologies for duplicating #117, I did this before checking if anyone had already done it, although I have got the tests working properly.
I also updated testing so that there is a script for updating fixtures, which should obviously only be run for major bumps.
Since
AllPackagesis no longer included in MathJax, I had to write our own, which meant enabling side effects for the package.