Skip to content

Followup for doc page action site shared#6795

Open
carlosabadia wants to merge 1 commit into
mainfrom
carlos/doc-page-action-followup
Open

Followup for doc page action site shared#6795
carlosabadia wants to merge 1 commit into
mainfrom
carlos/doc-page-action-followup

Conversation

@carlosabadia

Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia
carlosabadia requested a review from a team as a code owner July 17, 2026 19:06
@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Jul 17, 2026
@greptile-apps

greptile-apps Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a single optional keyword-only parameter, llms_label, to docs_page_actions so callers can supply a custom display label for the "View all docs as Markdown for LLMs" menu item. The default value "llms-full.txt" preserves full backward compatibility.

  • llms_label: str = "llms-full.txt" is placed after the * separator, keeping it keyword-only and non-breaking for every existing call site.
  • The docstring is updated to document the new parameter, and the hardcoded string in the _menu_item call is replaced with the parameter value.

Confidence Score: 5/5

Safe to merge — the change is a small, backward-compatible addition with no functional risk.

The only change is replacing a hardcoded string with an optional parameter that defaults to the same string. No logic, state, or rendering behaviour is altered for existing callers.

No files require special attention.

Important Files Changed

Filename Overview
packages/reflex-site-shared/src/reflex_site_shared/components/docs_page_actions.py Adds an optional keyword-only llms_label parameter with a backward-compatible default of "llms-full.txt" so callers can customise the menu item title for the agent-readable docs link.

Reviews (1): Last reviewed commit: "Followup for doc page action site shared" | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Jul 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing carlos/doc-page-action-followup (2b9e0e8) with main (f79d011)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant