Skip to content

Drop Python 3.8 support - #258

Merged
uglide merged 1 commit into
masterfrom
im/drop-python-3.8
Oct 15, 2026
Merged

uglide merged 1 commit into
masterfrom
im/drop-python-3.8

Conversation

@uglide

@uglide uglide commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

What

  • setup.py: raise python_requires from >=3.8 to >=3.9 and drop the Python :: 3.8 classifier.
  • tox.ini: black linter now uses --target-version py39 (was py37).

Why

Python 3.8 is EOL. CI already tests only 3.9+ and the README already says hiredis-py requires Python 3.9+, but the package metadata still advertised 3.8. As a result, pip would still install new releases on 3.8, and cibuildwheel (which reads python_requires from setup.py) would keep building cp38 wheels.

Notes for reviewers

  • No workflow changes needed: the CI matrices already exclude 3.8, and cibuildwheel skips cp38 once python_requires is bumped.
  • The C sources have no PY_VERSION_HEX guards, so nothing to clean up there.
  • Verified locally: a built wheel's METADATA shows Requires-Python: >=3.9, and pytest passes (65 tests, Python 3.11).
  • Should be mentioned in the next GitHub release notes as a breaking change for 3.8 users.

🤖 Generated with Claude Code


Note

Low Risk
Packaging and linter config only; no runtime or C extension logic changes.

Overview
Raises the minimum supported Python version to 3.9 so package metadata and tooling match EOL 3.8 and existing CI/README.

In setup.py, python_requires changes from >=3.8 to >=3.9, and the PyPI classifier for Python 3.8 is removed. Pip will no longer install new releases on 3.8, and cibuildwheel will stop producing cp38 wheels.

In tox.ini, Black’s --target-version is updated from py37 to py39 for the linters env.

Reviewed by Cursor Bugbot for commit 4980b12. Bugbot is set up for automated code reviews on this repo. Configure here.

Python 3.8 is EOL and CI already tests only 3.9+, and the README
already states 3.9+ is required. Bring the package metadata in line:
raise python_requires to >=3.9 (which also stops cibuildwheel from
building cp38 wheels), drop the 3.8 classifier, and target py39 in
the black linter config.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@uglide
uglide merged commit 6de39f7 into master Oct 15, 2026
35 checks passed
@uglide
uglide deleted the im/drop-python-3.8 branch October 15, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant