Repository navigation
Drop Python 3.8 support - #258
Merged
Merged
Conversation
Python 3.8 is EOL and CI already tests only 3.9+, and the README already states 3.9+ is required. Bring the package metadata in line: raise python_requires to >=3.9 (which also stops cibuildwheel from building cp38 wheels), drop the 3.8 classifier, and target py39 in the black linter config. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
setup.py: raisepython_requiresfrom>=3.8to>=3.9and drop thePython :: 3.8classifier.tox.ini: black linter now uses--target-version py39(waspy37).Why
Python 3.8 is EOL. CI already tests only 3.9+ and the README already says hiredis-py requires Python 3.9+, but the package metadata still advertised 3.8. As a result, pip would still install new releases on 3.8, and cibuildwheel (which reads
python_requiresfromsetup.py) would keep buildingcp38wheels.Notes for reviewers
cp38oncepython_requiresis bumped.PY_VERSION_HEXguards, so nothing to clean up there.Requires-Python: >=3.9, andpytestpasses (65 tests, Python 3.11).🤖 Generated with Claude Code
Note
Low Risk
Packaging and linter config only; no runtime or C extension logic changes.
Overview
Raises the minimum supported Python version to 3.9 so package metadata and tooling match EOL 3.8 and existing CI/README.
In
setup.py,python_requireschanges from>=3.8to>=3.9, and the PyPI classifier for Python 3.8 is removed. Pip will no longer install new releases on 3.8, and cibuildwheel will stop producingcp38wheels.In
tox.ini, Black’s--target-versionis updated frompy37topy39for the linters env.Reviewed by Cursor Bugbot for commit 4980b12. Bugbot is set up for automated code reviews on this repo. Configure here.