Skip to content

Remove Orion tests with no matching ES data - #1278

Open
arpsharm wants to merge 1 commit into
mainfrom
fix-orion-impossible-tests
Open

Remove Orion tests with no matching ES data#1278
arpsharm wants to merge 1 commit into
mainfrom
fix-orion-impossible-tests

Conversation

@arpsharm

@arpsharm arpsharm commented Aug 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove Orion config tests that reference metadata combinations with no data in Elasticsearch
  • When any test has no matching UUID, Orion calls sys.exit(3) and discards ALL results for the entire workload — including tests that passed
  • Root cause of CloudSensei workload count dropping from 170 → 82

Changes

Config Before After Removed
perfci-hammerdb.yaml 96 78 12 win2k25 + 6 scale (no ES data)
perfci-vdbench.yaml 30 28 2 64kb_write_16threads (no ES data)
perfci-windows-bootstorm.yaml 3 2 1 windows_server_2025 (workload removed)

Summary by CodeRabbit

  • Test Configuration Updates
    • Updated HammerDB performance scenarios for VM and pod deployments across MSSQL, MariaDB, and PostgreSQL.
    • Added CentOS Stream 10 and Windows Server 2025 metadata to selected MSSQL VM scenarios.
    • Removed outdated scale-storage MSSQL scenarios and two Vdbench workload tests.
    • Updated Windows bootstorm coverage for Windows 11 and Windows Server 2022.
    • Removed the Windows Server 2025 bootstorm configuration.

Remove tests that reference metadata combinations with no data in
Elasticsearch, causing Orion to exit(3) and discard all results for
the entire workload config.

- perfci-hammerdb.yaml: 96 → 78 (remove 12 win2k25, 6 scale)
- perfci-vdbench.yaml: 30 → 28 (remove 2 64kb_write_16threads)
- perfci-windows-bootstorm.yaml: 3 → 2 (remove windows_server_2025)
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c4d04049-d249-4ed1-bb6b-9d738ad97156

📥 Commits

Reviewing files that changed from the base of the PR and between a01c92f and 33a8c34.

📒 Files selected for processing (3)
  • orion-configs/perfci-hammerdb.yaml
  • orion-configs/perfci-vdbench.yaml
  • orion-configs/perfci-windows-bootstorm.yaml
💤 Files with no reviewable changes (1)
  • orion-configs/perfci-vdbench.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The PR normalizes benchmark YAML list indentation, updates ODF MSSQL VM OS metadata, removes selected HammerDB and Vdbench scenarios, and changes Windows bootstorm coverage from Windows Server 2025 to Windows Server 2022.

Changes

Benchmark configuration updates

Layer / File(s) Summary
HammerDB matrix and scenario cleanup
orion-configs/perfci-hammerdb.yaml, orion-configs/perfci-vdbench.yaml
HammerDB ODF and LSO matrices retain their database, deployment, worker, and TPM settings. ODF MSSQL VM cases add CentOS Stream 10 or Windows Server 2025 metadata. Scale-storage MSSQL VM cases and two Vdbench scenarios are removed.
Windows bootstorm coverage
orion-configs/perfci-windows-bootstorm.yaml
Windows 11 and Windows Server 2022 tests retain the existing average metric thresholds. The Windows Server 2025 test is removed.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to 33a8c

The change removes configuration entries without matching data, preventing valid workload results from being discarded. No actionable merge-blocking risk remains at the current head after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary change: removing Orion tests without matching Elasticsearch data.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-orion-impossible-tests

Comment @coderabbitai help to get the list of available commands.

@ebattat ebattat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arpsharm, ebattat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants