Remove Orion tests with no matching ES data - #1278
Conversation
Remove tests that reference metadata combinations with no data in Elasticsearch, causing Orion to exit(3) and discard all results for the entire workload config. - perfci-hammerdb.yaml: 96 → 78 (remove 12 win2k25, 6 scale) - perfci-vdbench.yaml: 30 → 28 (remove 2 64kb_write_16threads) - perfci-windows-bootstorm.yaml: 3 → 2 (remove windows_server_2025)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe PR normalizes benchmark YAML list indentation, updates ODF MSSQL VM OS metadata, removes selected HammerDB and Vdbench scenarios, and changes Windows bootstorm coverage from Windows Server 2025 to Windows Server 2022. ChangesBenchmark configuration updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The change removes configuration entries without matching data, preventing valid workload results from being discarded. No actionable merge-blocking risk remains at the current head after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arpsharm, ebattat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
sys.exit(3)and discards ALL results for the entire workload — including tests that passedChanges
64kb_write_16threads(no ES data)windows_server_2025(workload removed)Summary by CodeRabbit