Conversation
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arpsharm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| self._environment_variables_dict['cdi_source_s3_cred'] = EnvironmentVariables.get_env('CDI_SOURCE_S3_CRED', '') | ||
| # Storage class for all VM workloads PVCs (override for clusters with different ODF config) | ||
| self._environment_variables_dict['vm_storage_class'] = EnvironmentVariables.get_env('VM_STORAGE_CLASS', 'ocs-storagecluster-ceph-rbd-virtualization') | ||
| self._environment_variables_dict['vm_access_mode'] = EnvironmentVariables.get_env('VM_ACCESS_MODE', 'ReadWriteMany') |
There was a problem hiding this comment.
Do we need to add it for all the workloads ?
| if 'win' in self.__workload_name: | ||
| answer['windows_dv.yaml'] = render_yaml_file(dir_path=os.path.join(workload_dir_path, 'internal_data'), yaml_file='windows_dv_template.yaml', environment_variable_dict=render_data) | ||
| dv_filename = f'windows_dv_{scale_node}.yaml' if render_data.get('per_node_dv') and scale_node else 'windows_dv.yaml' | ||
| answer[dv_filename] = render_yaml_file(dir_path=os.path.join(workload_dir_path, 'internal_data'), yaml_file='windows_dv_template.yaml', environment_variable_dict=render_data) |
There was a problem hiding this comment.
Did u check that other windows workloads work properly ?
| create_infra.migrate_infra() | ||
| elif 'lvms' == resource: | ||
| lvms_version = self.__environment_variables_dict.get('lvms_version', '') | ||
| lvms_devices = ast.literal_eval(self.__environment_variables_dict.get('lvms_devices', "['/dev/nvme0n1', '/dev/nvme1n1']")) |
There was a problem hiding this comment.
I think ilvms_devices should be in environment variables and not hard coded
| # odf version | ||
| self._environment_variables_dict['odf_version'] = EnvironmentVariables.get_env('ODF_VERSION', '') | ||
| # lvms version | ||
| self._environment_variables_dict['lvms_version'] = EnvironmentVariables.get_env('LVMS_VERSION', '4.22') |
There was a problem hiding this comment.
Why u put hard coded lvm 4.22 ?
| self._created_sc_name = '' | ||
|
|
||
| def _create_snapshot_clone_sc(self): | ||
| """Create a StorageClass with snapshot clone strategy for fast LVMS cloning""" |
There was a problem hiding this comment.
Will it support LVM and ODF or just LVM ?
2 participants
Summary